-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Issue #9675: [Remote Store] Add negative test cases and improve cluster stability validation in RemoteStoreRepositoryRegistrationIT #18860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c8b95d8
to
92f7517
Compare
❌ Gradle check result for 92f7517: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
92f7517
to
ee58d5d
Compare
❌ Gradle check result for ee58d5d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ee58d5d
to
ee135ee
Compare
❌ Gradle check result for ee135ee: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ee135ee
to
ce36fc9
Compare
❌ Gradle check result for ce36fc9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ce36fc9
to
703048c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18860 +/- ##
============================================
+ Coverage 72.77% 72.83% +0.06%
- Complexity 68690 68833 +143
============================================
Files 5582 5587 +5
Lines 315456 315719 +263
Branches 45778 45817 +39
============================================
+ Hits 229568 229955 +387
+ Misses 67290 67173 -117
+ Partials 18598 18591 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...internalClusterTest/java/org/opensearch/remotestore/RemoteStoreRepositoryRegistrationIT.java
Show resolved
Hide resolved
...internalClusterTest/java/org/opensearch/remotestore/RemoteStoreRepositoryRegistrationIT.java
Show resolved
Hide resolved
Thanks for raising the PR @night-owl-1709 ! Are you planning to cover all the test cases mentioned in #9675 ? If not, we can just check mark the ones you cover in this PR and keep the issue open |
…strationIT Signed-off-by: Abhinav Tripathi <[email protected]>
703048c
to
c20cbcd
Compare
…strationIT (opensearch-project#18860) Signed-off-by: Abhinav Tripathi <[email protected]>
Description
This PR adds comprehensive negative test cases to RemoteStoreRepositoryRegistrationIT to improve test coverage for remote store functionality. The added tests verify proper error handling and validation during node join scenarios that should fail.
Added Test Cases:
These negative test cases enhance the robustness of remote store functionality by ensuring proper validation and error handling during cluster formation and node lifecycle operations.
Related Issues
Implements 4 negative scenarios for #9675
Check List
Notes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.