Skip to content

Conversation

night-owl-1709
Copy link
Contributor

@night-owl-1709 night-owl-1709 commented Jul 29, 2025

Description

This PR adds comprehensive negative test cases to RemoteStoreRepositoryRegistrationIT to improve test coverage for remote store functionality. The added tests verify proper error handling and validation during node join scenarios that should fail.

Added Test Cases:

  1. testNodeJoinFailureWithDifferentRemoteStoreRepositoryAttributes - Tests incompatible remote store configurations
  2. testNodeRejoinFailureWithChangedRemoteStoreAttributes - Tests node rejoin failure with changed attributes
  3. testNodeJoinFailureWithMissingRemoteStoreAttributes - Tests missing remote store attributes
  4. testRepositoryVerificationFailureDuringNodeJoin - Tests repository verification failure with invalid repository types

These negative test cases enhance the robustness of remote store functionality by ensuring proper validation and error handling during cluster formation and node lifecycle operations.

Related Issues

Implements 4 negative scenarios for #9675

Check List

Notes:

  • No API changes were made (only added test cases)
  • No public documentation needed (internal test improvements)
  • All changes are test-only additions to improve coverage

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@night-owl-1709 night-owl-1709 requested a review from a team as a code owner July 29, 2025 12:43
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Storage Issues and PRs relating to data and metadata storage Storage:Remote labels Jul 29, 2025
@night-owl-1709 night-owl-1709 changed the title [Remote Store] Adding negative test case in RemoteStoreRepositoryRegistrationIT #9675 [Remote Store] Adding negative test case in RemoteStoreRepositoryRegistrationIT Jul 29, 2025
@night-owl-1709 night-owl-1709 force-pushed the add-negative-tests-remote-store-registration branch 2 times, most recently from c8b95d8 to 92f7517 Compare July 29, 2025 12:59
Copy link
Contributor

❌ Gradle check result for 92f7517: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@night-owl-1709 night-owl-1709 force-pushed the add-negative-tests-remote-store-registration branch from 92f7517 to ee58d5d Compare July 30, 2025 07:36
Copy link
Contributor

❌ Gradle check result for ee58d5d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@night-owl-1709 night-owl-1709 force-pushed the add-negative-tests-remote-store-registration branch from ee58d5d to ee135ee Compare July 30, 2025 07:52
Copy link
Contributor

❌ Gradle check result for ee135ee: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ce36fc9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 703048c: SUCCESS

Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.83%. Comparing base (9b22c9b) to head (c20cbcd).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18860      +/-   ##
============================================
+ Coverage     72.77%   72.83%   +0.06%     
- Complexity    68690    68833     +143     
============================================
  Files          5582     5587       +5     
  Lines        315456   315719     +263     
  Branches      45778    45817      +39     
============================================
+ Hits         229568   229955     +387     
+ Misses        67290    67173     -117     
+ Partials      18598    18591       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@linuxpi
Copy link
Contributor

linuxpi commented Aug 1, 2025

Thanks for raising the PR @night-owl-1709 ! Are you planning to cover all the test cases mentioned in #9675 ?

If not, we can just check mark the ones you cover in this PR and keep the issue open

@linuxpi linuxpi moved this to 🏗 In progress in Storage Project Board Aug 1, 2025
@night-owl-1709 night-owl-1709 force-pushed the add-negative-tests-remote-store-registration branch from 703048c to c20cbcd Compare August 1, 2025 14:35
@night-owl-1709 night-owl-1709 changed the title [Remote Store] Adding negative test case in RemoteStoreRepositoryRegistrationIT Issue #9675: [Remote Store] Add negative test cases and improve cluster stability validation in RemoteStoreRepositoryRegistrationIT Aug 1, 2025
Copy link
Contributor

github-actions bot commented Aug 1, 2025

✅ Gradle check result for c20cbcd: SUCCESS

@github-project-automation github-project-automation bot moved this from 🏗 In progress to 👀 In review in Storage Project Board Aug 5, 2025
@linuxpi linuxpi merged commit b21c59e into opensearch-project:main Aug 5, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Storage Project Board Aug 5, 2025
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers skip-changelog Storage:Remote Storage Issues and PRs relating to data and metadata storage

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants