Ignore archived settings on update #18885
Conversation
Prior to this change all settings updates would fail if archived settings were present, even when attempting to update unrelated settings. This change ignores archived settings when validating a settings update. Signed-off-by: Andrew Ross <[email protected]>
github-actions
bot
added
API
|
❌ Gradle check result for 84be826: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 84be826: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 84be826: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Andrew Ross <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18885 +/- ##
============================================
+ Coverage 72.77% 72.84% +0.07%
- Complexity 68690 68842 +152
============================================
Files 5582 5590 +8
Lines 315456 315809 +353
Branches 45778 45829 +51
============================================
+ Hits 229568 230050 +482
+ Misses 67290 67177 -113
+ Partials 18598 18582 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prior to this change all settings updates would fail if archived settings were present, even when attempting to update unrelated settings. This change ignores archived settings when validating a settings update. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: sunqijun.jun <[email protected]>
Prior to this change all settings updates would fail if archived settings were present, even when attempting to update unrelated settings. This change ignores archived settings when validating a settings update. Signed-off-by: Andrew Ross <[email protected]>
Prior to this change all settings updates would fail if archived settings were present, even when attempting to update unrelated settings. This change ignores archived settings when validating a settings update.
Related Issues
Resolves #8714
Resolves #18515
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.