Skip to content

Guard eclipse() to spotless tasks and keep P2 mirror on pinned version (asynchronous-search) - #867

Open
peterzhuamazon wants to merge 1 commit into
opensearch-project:mainfrom
peterzhuamazon:eclipse-pin-separation
Open

Guard eclipse() to spotless tasks and keep P2 mirror on pinned version (asynchronous-search)#867
peterzhuamazon wants to merge 1 commit into
opensearch-project:mainfrom
peterzhuamazon:eclipse-pin-separation

Conversation

@peterzhuamazon

Copy link
Copy Markdown
Member

Description

Guard eclipse() to spotless tasks and keep P2 mirror on pinned version.

Issues Resolved

opensearch-project/opensearch-build#6421

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…n (asynchronous-search)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon

Copy link
Copy Markdown
Member Author

expected version pin

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit bf14194.

Hard block: Issues at High severity or above will block this PR from merging.

PathLineSeverityDescription
build.gradle49highBuild plugin version change: 'com.diffplug.spotless' bumped from 6.25.0 to 8.10.1 (a major version jump across two major versions). Per mandatory rule, all build plugin changes must be flagged regardless of apparent legitimacy — maintainers should verify the artifact on the Gradle Plugin Portal matches the expected publisher and checksum.
gradle/formatting.gradle26highEclipse JDT formatter dependency version explicitly pinned to '4.29' where previously no version was specified (resolved automatically). The accompanying comment states this causes resolution to shift from a P2 update site to Maven Central via the ci.opensearch.org mirror. This is a dependency artifact change and must be verified — maintainers should confirm the artifact published to Maven Central under this coordinate matches the expected Eclipse formatter.

The table above displays the top 10 most important findings.

Total: 2 | Critical: 0 | High: 2 | Medium: 0 | Low: 0


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@peterzhuamazon peterzhuamazon added the skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. label Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.19 backport 3.8 enhancement New feature or request release skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. v3.9.0 Version 3.9.0

Projects

Status: 👀 In Review
Status: In review

Development

Successfully merging this pull request may close these issues.

1 participant