Repository navigation
Conversation
Adds a reserved role that can send messages through existing Notifications channels without being able to create, update or delete them: cluster:admin/opensearch/notifications/feature/send, plus channels/get and features so the caller can choose a channel. Related: opensearch-project/notifications#1279 Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep
requested review from
DarshitChanpura,
Rishav9852Kumar,
RyanL1997,
cwperks,
derek-ho,
finnegancarroll,
nibix,
reta,
shikharj05 and
willyborankin
as code owners
October 5, 2026 23:12
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
cwperks
reviewed
Oct 6, 2026
| reserved: true | ||
| cluster_permissions: | ||
| - 'cluster:admin/opensearch/notifications/channels/get' | ||
| - 'cluster:admin/opensearch/notifications/feature/send' |
Member
There was a problem hiding this comment.
Why is this called feature/send opposed to channel/send?
cwperks
approved these changes
Oct 6, 2026
cwperks
reviewed
Oct 6, 2026
| - 'cluster:admin/opensearch/notifications/features' | ||
|
|
||
| # Allows users to send messages through existing Notifications channels | ||
| notifications_send_access: |
Member
There was a problem hiding this comment.
wdyt about simplifying this to notifications_send?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a reserved role,
notifications_send_access, for callers that send messages through existing Notifications channels but must not manage them.cluster:admin/opensearch/notifications/feature/send. Today the only reserved role that grants it isnotifications_full_access, which also grants channel create, update and delete.notifications_full_access.notifications_send_accessnow grantsfeature/send,channels/getandfeatures, with noconfigs/*action.notifications_send_accessnotifications/channels/get,notifications/feature/send,notifications/featuresIssues Resolved
Related: opensearch-project/notifications#1279
Is this a backport? No.
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? No.
cluster:admin/opensearch/notifications/feature/sendis an existing action.Testing
node check-permissions-order.js config/roles.ymlpasses. The role's permission set is exercised by the security-enabled integration tests in opensearch-project/notifications.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.