Scaffolding: top/rare useOther and percentage arguments #4335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
RyanL1997,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
Swiddis
commented
Sep 19, 2025
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
RyanL1997
reviewed
Sep 22, 2025
core/src/main/java/org/opensearch/sql/ast/tree/args/RareTopNArguments.java
Show resolved
Hide resolved
ppl/src/test/java/org/opensearch/sql/ppl/utils/PPLQueryDataAnonymizerTest.java
Outdated
Show resolved
Hide resolved
|
Doc changes will come when the features are actually supported -- they'll currently just raise errors so no point documenting (they'd fail doctest anyway) |
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
commented
Sep 22, 2025
| - id: spotless-check | ||
| name: Spotless Post-format Check | ||
| entry: bash -c './gradlew spotlessCheck' | ||
| entry: bash -c './gradlew spotlessApply spotlessCheck && git add -u' |
There was a problem hiding this comment.
small build change, makes precommit faster (check always runs after apply)
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR 1/3: this PR adds some parsing logic and does a bit of plumbing related to upcoming arguments. This doesn't include the actual implementation. useOther and showPerc will be the other two PRs.
Depending on how complex those are, I might also be able to hit #4278 and #4282 in the same go, since composite buckets of terms support sorting by count. I'd also want to switch to the rare_terms aggregator for
rare, per the warning on the linked doc.Exactly how to get a total for other/percentage is still somewhat open. I thought earlier that I could subtract from a cheap
_countcall, but I didn't notice at the time that you could also supply filters before the inputs which invalidates that method. Going to poke at the DSL a bit more & see what we end up with (worst case we end up going by all returned buckets, which hits issues if there's too many buckets).Related Issues
N/A
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.