Publish internal modules separately for downstream reuse #4484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project#3763) * Add common Gradle task for all published modules Signed-off-by: Chen Dai <[email protected]> * Add publish workflow file Signed-off-by: Chen Dai <[email protected]> * Rename group ID from sql to query Signed-off-by: Chen Dai <[email protected]> --------- Signed-off-by: Chen Dai <[email protected]>
* Add api module with API and UT Signed-off-by: Chen Dai <[email protected]> * Refactor catalog API and clean up build.gradle Signed-off-by: Chen Dai <[email protected]> * Add cache schema API and refactor UT Signed-off-by: Chen Dai <[email protected]> * Add readme Signed-off-by: Chen Dai <[email protected]> * Add comment for hardcoding query size limit Signed-off-by: Chen Dai <[email protected]> * Add default namespace API with more UTs Signed-off-by: Chen Dai <[email protected]> --------- Signed-off-by: Chen Dai <[email protected]>
…-project#4015) * add datasources submodule Signed-off-by: cnoramut <[email protected]> * add legacy since datasources need it Signed-off-by: cnoramut <[email protected]> --------- Signed-off-by: cnoramut <[email protected]> Signed-off-by: Louis Chu <[email protected]> Co-authored-by: Louis Chu <[email protected]>
Swiddis
changed the title
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
commented
Oct 9, 2025
| /** | ||
| * A DataSourceService that assumes no access to data sources | ||
| */ | ||
| public class EmptyDataSourceService implements DataSourceService { |
There was a problem hiding this comment.
Since CalciteRelNodeVisitor needs a data source service now, but this notion doesn't make any sense outside of a cluster, let's just fill in an empty one that always returns no results and reports any given source as nonexistent.
Better solution long-term would be to make CalciteRelNodeVisitor not have this dependency to begin with, seems like it crosses boundaries.
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
GumpacG,
MaxKsyunz,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
ps48,
seankao-az and
vamsimanohar
as code owners
Swiddis
requested review from
LantaoJin,
RyanL1997,
noCharger,
qianheng-aws,
ykmr1224 and
yuancu
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copy of #4385 but merged with main, trying to see what's broken with tests
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.