Skip to content

WIP: Support chart command in PPL #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

WIP: Support chart command in PPL #4579

wants to merge 16 commits into from

Conversation

@yuancu
Copy link
Collaborator

@yuancu yuancu commented Oct 16, 2025 •
edited
Loading

Description

The chart command returns an aggregation result in a two-dimension table format.

TODOs:

  • support span
  • support limit, limit=top x, limit=bottom x
  • support useother, otherstr
  • correct limit behavior with non-accumulative aggregation functions (min, max, avg, etc) // fixed in Fix timechart OTHER category aggregation for non-cumulative functions #4594
  • support usenull, nullstr
  • support non-string fields as column split
  • add integration tests
  • support multiple aggregation functions
  • add explain tests
  • add a doc
  • unify implementation of timechart and chart
  • Add a brief walk-through of the implementation

Related Issues

Resolves #399

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@yuancu yuancu added the feature label Oct 16, 2025
yuancu added 15 commits October 24, 2025 14:10
@yuancu
WIP: Make poc implementation for chart command
82cac9b 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Support param useother and otherstr
c5e11de 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Support usenull and nullstr (when both row split and col split present)
bcb6c68 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Append a final aggregation to merge OTHER categories
14a7d7c 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Handle common agg functions for OTHER category for timechart
9d19a44 
Signed-off-by: Yuanchun Shen <[email protected]>

# Conflicts:
#	core/src/main/java/org/opensearch/sql/calcite/CalciteRelNodeVisitor.java
#	integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java
@yuancu
Fix timechart IT
ddccedc 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Sort earliest results with asc order
226e3c1 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Support non-string fields as column split
9eb3180 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Fix min/earliest order & fix non-accumulative agg for chart
d301ff0 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Hint non-null in aggregateWithTrimming
b10608d 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Add integration tests for chart command
b14920d 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Add unit tests
2332e24 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Add doc for chart command
585cd51 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Prompt users that multiple agg is not supported
efeb8e2 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu
Add explain ITs
6b8934e 
Signed-off-by: Yuanchun Shen <[email protected]>
@yuancu yuancu marked this pull request as ready for review October 24, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar vamsimanohar is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

@qianheng-aws qianheng-aws Awaiting requested review from qianheng-aws qianheng-aws is a code owner

@RyanL1997 RyanL1997 Awaiting requested review from RyanL1997 RyanL1997 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC] PPL Chart Command

1 participant

@yuancu