- 
                Notifications
    You must be signed in to change notification settings 
- Fork 41
move operatorhub test case to the Console component #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jian Zhang <[email protected]>
| Hi @jianzhangbjz. Thanks for your PR. I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. | 
| Hi, Console team leader @yapei , could you help approve it? Thanks! | 
| Hi @stbenjam , could you help approve it too? Thanks! | 
| {Suite: "Operator Hub tests"}, | ||
| {Suite: "operatorhub feature related"}, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need move lines here? They should automatically matched to ManagementConsole once deleted from OLM matchers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I’d rather play it safe. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
| /lgtm | 
| @yapei: changing LGTM is restricted to collaborators In response to this: 
 Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. | 
| [APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jianzhangbjz, yapei The full list of commands accepted by this bot can be found here. 
Needs approval from an approver in each of these files:
 Approvers can indicate their approval by writing  | 
| /ok-to-test I think you're missing  | 
These

Operator Hub teststest cases belong to the Console team, not OLM. So update the case mapping. See:OLM / OperatorHub > Other