Skip to content

Conversation

@jianzhangbjz
Copy link
Contributor

These Operator Hub tests test cases belong to the Console team, not OLM. So update the case mapping. See:
OLM / OperatorHub > Other
image

@openshift-ci openshift-ci bot requested review from neisw and xueqzhan May 21, 2025 09:26
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2025

Hi @jianzhangbjz. Thanks for your PR.

I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jianzhangbjz
Copy link
Contributor Author

jianzhangbjz commented May 21, 2025

Hi, Console team leader @yapei , could you help approve it? Thanks!

@jianzhangbjz
Copy link
Contributor Author

Hi @stbenjam , could you help approve it too? Thanks!

Comment on lines +34 to +35
{Suite: "Operator Hub tests"},
{Suite: "operatorhub feature related"},
Copy link
Contributor

@yapei yapei May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need move lines here? They should automatically matched to ManagementConsole once deleted from OLM matchers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I’d rather play it safe. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@yapei
Copy link
Contributor

yapei commented May 22, 2025

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2025

@yapei: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jianzhangbjz, yapei
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member

/ok-to-test

I think you're missing make mapping. You can also join the openshift-eng org to get your PR's automatically tested

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants