-
Notifications
You must be signed in to change notification settings - Fork 17
Refactor workflow to leverage Submission module #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dd6896b
to
d76748b
Compare
Great point. I actually think the original intention here was to emit a message to the user when In other cases where In this case, community/redhat charts were never automerged anyway, so the only outcome we'd have is being able to provide user feedback via comments. At least for the community/redhat categories, I don't see logic to actually pass through that feedback coming from this workflow. To that end, we can fail the workflow for now. That seems like an overall improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
No description provided.