Skip to content

WIP: Disable the controllers for KafkaNamespaced Broker/Trigger controllers to avoid issues. #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: Disable the controllers for KafkaNamespaced Broker/Trigger controllers to avoid issues. #3685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion knative-operator/pkg/controller/knativekafka/knativekafka_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ func configureEventingKafka(spec serverlessoperatorv1alpha1.KnativeKafkaSpec) mf
if u.GetKind() == "Deployment" && u.GetName() == "kafka-controller" {

var disabledKafkaControllers = common.StringMap{
brokerController: "broker-controller,trigger-controller,namespaced-broker-controller,namespaced-trigger-controller",
brokerController: "broker-controller,trigger-controller",
sinkController: "sink-controller",
sourceController: "source-controller",
channelController: "channel-controller",
Expand Down
4 changes: 2 additions & 2 deletions knative-operator/pkg/controller/knativekafka/knativekafka_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ func TestDisabledControllers(t *testing.T) {
Enabled: true,
},
},
expectedDisabledControllers: []string{"broker-controller", "trigger-controller", "namespaced-broker-controller", "namespaced-trigger-controller", "source-controller"},
expectedDisabledControllers: []string{"broker-controller", "trigger-controller", "source-controller"},
}, {
name: "broker and sink",
knativeKafka: v1alpha1.KnativeKafkaSpec{
Expand All @@ -629,7 +629,7 @@ func TestDisabledControllers(t *testing.T) {
Enabled: false,
},
},
expectedDisabledControllers: []string{"broker-controller", "trigger-controller", "namespaced-broker-controller", "namespaced-trigger-controller", "sink-controller", "source-controller"},
expectedDisabledControllers: []string{"broker-controller", "trigger-controller", "sink-controller", "source-controller"},
}}

for _, test := range tests {
Expand Down
Loading