AGENT-1193: Custom openshift-install can be used by appliance #1775
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-metal-ipi-serial-ipv4 Testing out if lane passes |
If the openshift-install binary was built from source, this change copies it to it in the appliance's asset directory. Placing it in the asset directory will signal to the appliance to use it instead of downloading it from the release. This allows us to test changes in the installer repo without having to wait for it to merge and appear in an offcial release image. Hard coding to version 4.19 in the directory structures used by the *agent_iso_no_registry functions has also be removed.
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@rwsu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
If the openshift-install binary was built from source, this change creates a symlink to it in the appliance's asset directory. Placing it in the asset directory will signal to the appliance to use it instead of downloading it from the release.
This allows us to test changes in the installer repo without having to wait for it to merge and appear in an offcial release image.
Hard coding to version 4.19 in the directory structures used by the *agent_iso_no_registry functions has also be removed.
Works in conjunction with: openshift/agent-installer-utils#122