-
Notifications
You must be signed in to change notification settings - Fork 561
OTA-1580: Promote UpgradeStatus
to Default
#2418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTA-1580: Promote UpgradeStatus
to Default
#2418
Conversation
@petr-muller: This pull request references OTA-1580 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hello @petr-muller! Some important instructions when contributing to openshift/api: |
@petr-muller: This pull request references OTA-1580 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold Hold for the OTA-1578 / openshift/cluster-version-operator#1216 dependency |
@petr-muller: This pull request references OTA-1580 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@petr-muller: This pull request references OTA-1580 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold cancel |
We agreed to gate this PR on a started SBAR process. /hold |
/test verify-feature-promotion |
/test ci/prow/verify-feature-promotion |
@petr-muller: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test verify-feature-promotion |
7 similar comments
/test verify-feature-promotion |
/test verify-feature-promotion |
/test verify-feature-promotion |
/test verify-feature-promotion |
/test verify-feature-promotion |
/test verify-feature-promotion |
/test verify-feature-promotion |
be85fbe
to
3fa6e41
Compare
UpgradeStatus
to Default (tests only)UpgradeStatus
to Default
/hold cancel |
/lgtm |
/retest-required |
/lgtm |
OTA uses `UpgradeStatus` feature gate name to identify the CLI-side functionality described in OTA-1577 (`oc adm upgrade status` command). The `UpgradeStatus` feature gate does not enable any cluster-side functionality (neither API changes or any controller code). The actual functionality will be enabled in `oc` through openshift/oc#2063. The `UpgradeStatus` feature gate thus serves only as a vehicle to perform the data-driven promotion decision by tying the appropriate test coverage to this name so that the promotion criteria can be automatically checked. Therefore, this PR serves as a formal decision record only, and after it merges, it means openshift/oc#2063 is allowed to merge.
3fa6e41
to
3443c48
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, JoelSpeed, petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold
|
/hold cancel |
1 similar comment
@petr-muller: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6282350
into
openshift:master
OTA uses
UpgradeStatus
feature gate name to identify the CLI-side functionality described in OTA-1577 (oc adm upgrade status
command).The
UpgradeStatus
feature gate does not enable any cluster-side functionality (neither API changes or any controller code). The actual functionality will be enabled inoc
through openshift/oc#2063. TheUpgradeStatus
feature gate thus serves only as a vehicle to perform the data-driven promotion decision by tying the appropriate test coverage to this name so that the promotion criteria can be automatically checked.Therefore, this PR serves as a formal decision record only, and after it merges, it means openshift/oc#2063 is allowed to merge.