OCPBUGS-58212 Remove InsightsRuntimeExtractor Feature gate #2419
Conversation
|
Hello @jmesnil! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/S
|
Hey @jmesnil @tremes, this PR has come as a surprise, as far as I was concerned, this feature hasn't GA'd yet? Looking at sippy, I can't see any testing of the feature that would demonstrate that the feature is ready to GA either? I think there may have been some miscommunication on the expectations of how feature gates are supposed to work on this feature, as openshift/insights-operator#1081 is not supposed to have happened until at least 1 release after the feature is promoted in o/api. We would normally get the feature ready in tech preview, add gated tests, gather data about their stability, and then make a decision about when to promote them based on the test data. This document outlines the process in more detail. I guess it's too late now, though I need to check what the implications of this are. Our release pipelines build reports on promoted features and this feeds into the release notes, it's quite possible your feature has silently GA'd and the correct outgoing comms for it haven't happened as expected Do you have any automated testing reporting into component readiness for this feature? |
|
@JoelSpeed thanks for the input, I'll check with the Insights Operator team to get you the info you ask. |
|
/retest |
|
Hey @JoelSpeed @jmesnil, since yesterday the sippy should be showing the test results for the InsightsRuntimeExtractor. @JoelSpeed, could you please take a look at this and let me know if the tests look correct? |
openshift-merge-robot
added
the
needs-rebase
This feature is GA-ed since OCP 4.19 and there is no longer any code in the Insights Operator that is gated against it. Signed-off-by: Jeff Mesnil <[email protected]>
jmesnil
force-pushed
the
OCPBUGS-58212_remove_InsightsRuntimeExtractor_feature_gate
branch
from
d333205 to
2dd438a
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmesnil, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/hold Revision 2dd438a was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Single failure on a known flake, https://issues.redhat.com/browse/OCPBUGS-57658 /override ci/prow/e2e-aws-ovn-hypershift-conformance |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-hypershift-conformance In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 similar comment
|
Single failure on a known flake, https://issues.redhat.com/browse/OCPBUGS-57658 /override ci/prow/e2e-aws-ovn |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
3 similar comments
|
@jmesnil: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This feature is GA-ed since OCP 4.19 and there is no longer any code in the Insights Operator that is gated against it.
The feature gate referenced was removed from the Insights Operator in openshift/insights-operator#1081.
For reference, this feature gate was introduced in OcP 4.18 with #1976.