Skip to content

Conversation

@lance5890
Copy link
Contributor

@lance5890 lance5890 commented Aug 14, 2025

The BoundServiceAccountTokenVolume is enabled by default, and the auto-generated sa has also injected the service-ca.crt

kind of post-cleanup of #1142 and openshift/kubernetes#714

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2025
@openshift-ci-robot
Copy link

@lance5890: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance5890
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance5890
Copy link
Contributor Author

/cc @vrutkovs

@openshift-ci openshift-ci bot requested a review from vrutkovs August 14, 2025 01:29
@lance5890 lance5890 force-pushed the remove_automountServiceAccountToken branch from 08c8a6b to a7c1760 Compare August 14, 2025 01:34
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2025
@lance5890 lance5890 changed the title NO-JIRA: Use BoundServceAccountTokenVolume de default NO-JIRA: Use BoundServceAccountTokenVolume dy default Aug 14, 2025
@vrutkovs
Copy link
Contributor

Could you create a jira ticket with a more thorough description? We certainly need to discuss it first in order to avoid regressions - and consider backporting it too

@lance5890
Copy link
Contributor Author

lance5890 commented Aug 14, 2025

Could you create a jira ticket with a more thorough description? We certainly need to discuss it first in order to avoid regressions - and consider backporting it too

I will create a Jira ticket for this. The change has been tested in my local cluster, and I'll share more details soon. Do you think this PR deserves an /ok-to-test to verify if it works in the ocp CI environment?

@lance5890 lance5890 changed the title NO-JIRA: Use BoundServceAccountTokenVolume dy default OCPBUGS-60496: Use BoundServceAccountTokenVolume dy default Aug 14, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 14, 2025
@openshift-ci-robot
Copy link

@lance5890: This pull request references Jira Issue OCPBUGS-60496, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The BoundServiceAccountTokenVolume is enabled by default, and the auto-generated sa has also injected the service-ca.crt

kind of post-cleanup of #1142 and openshift/kubernetes#714

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs
Copy link
Contributor

Ah, yes, sure
/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2025
@vrutkovs
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 14, 2025
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-60496, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

@lance5890: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn a7c1760 link false /test e2e-azure-ovn
ci/prow/okd-scos-e2e-aws-ovn a7c1760 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade a7c1760 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-operator-single-node a7c1760 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lance5890
Copy link
Contributor Author

lance5890 commented Aug 17, 2025

Could you create a jira ticket with a more thorough description? We certainly need to discuss it first in order to avoid regressions - and consider backporting it too

the related pr openshift/cluster-version-operator#660 will block the upgrade

need more investigation

@lance5890 lance5890 changed the title OCPBUGS-60496: Use BoundServceAccountTokenVolume dy default WIP:OCPBUGS-60496: Use BoundServceAccountTokenVolume dy default Aug 17, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2025
@lance5890
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2025
@lance5890
Copy link
Contributor Author

need to wait the openshift/cluster-version-operator#1225 to merge first

@lance5890 lance5890 changed the title WIP:OCPBUGS-60496: Use BoundServceAccountTokenVolume dy default OCPBUGS-60496: Use BoundServceAccountTokenVolume dy default Aug 18, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2025
runAsUser: 65534
seccompProfile:
type: RuntimeDefault
automountServiceAccountToken: false # here to prevent deadlock, remove in 4.9
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the automountServiceAccountToken should be supported within cvo for upgrading

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 23, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 23, 2025

Walkthrough

This change removes service account token mounting and related Kubernetes API access configuration from the kube-apiserver-operator deployment manifest. Specifically, it eliminates the automountServiceAccountToken directive, the kube-api-access volumeMount, and the projected volume containing token, CA bundle, and downwardAPI data.

Changes

Cohort / File(s) Change Summary
kube-apiserver-operator deployment configuration
manifests/0000_20_kube-apiserver-operator_06_deployment.yaml
Removed automountServiceAccountToken: false from pod spec; removed kube-api-access volumeMount from container spec; removed kube-api-access projected volume containing service account token, CA bundle, and downwardAPI references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Single manifest file with homogeneous changes (all removals of related configuration fields)
  • Verify intent — confirm that removing service account token access and API credentials from this deployment is intentional and necessary
  • Check downstream impact — ensure no dependent components or scripts rely on the removed kube-api-access volume or automountServiceAccountToken setting
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 36917f5 and a7c1760.

📒 Files selected for processing (1)
  • manifests/0000_20_kube-apiserver-operator_06_deployment.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • manifests/0000_20_kube-apiserver-operator_06_deployment.yaml

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants