OCPBUGS-65755: Stop serving VolumeAttributesClass v1beta1

[bertinatto]

Version v1 is available in Kubernetes 1.34.

/assign @benluddy

[openshift-ci-robot]

@bertinatto: This pull request references OCPSTRAT-2371 which is a valid jira issue.

In response to this:

Version v1 is available in Kubernetes 1.34.

/assign @benluddy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Removed the VolumeAttributesClass entry from defaultGroupVersionsByFeatureGate in pkg/operator/configobservation/apienablement/observe_runtime_config.go; no other mappings were modified.

Changes

Cohort / File(s)	Summary
Removal of feature-gate mapping pkg/operator/configobservation/apienablement/observe_runtime_config.go	Deleted the VolumeAttributesClass map entry that previously referenced GroupVersion{Group: "storage.k8s.io", Version: "v1beta1"} from defaultGroupVersionsByFeatureGate. No other entries changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Check for any references to VolumeAttributesClass or hardcoded storage.k8s.io/v1beta1 that may expect the mapping to exist.
• Verify runtime-config population tests or integration points that relied on the removed entry.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "OCPSTRAT-2371: Stop serving VolumeAttributesClass v1beta1" directly and clearly describes the main change in the pull request. The raw summary confirms that the primary change is the removal of the VolumeAttributesClass entry from the feature gate mapping, which aligns perfectly with the title's statement about stopping the serving of this API version. The title is concise, specific, and free of noise or vague terminology.
Description Check	✅ Passed	The PR description "Version v1 is available in Kubernetes 1.34" provides a meaningful rationale for the change. This statement directly relates to the changeset by explaining why VolumeAttributesClass v1beta1 is being removed—because the v1 version is now available in Kubernetes 1.34. While brief, the description conveys sufficient information about the motivation behind the change and is clearly relevant to the removal of v1beta1 support.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 3f99c6b and 24ccc18.

📒 Files selected for processing (1)

• pkg/operator/configobservation/apienablement/observe_runtime_config.go (0 hunks)

💤 Files with no reviewable changes (1)

• pkg/operator/configobservation/apienablement/observe_runtime_config.go

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[benluddy]

/lgtm

[bertinatto]

/retest-required

[bertinatto]

/retest-required

[bertinatto]

/test all

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

pkg/operator/configobservation/apienablement/observe_runtime_config.go (1)

31-33: Version range is correct.

VolumeAttributesClass graduated to GA (v1) in Kubernetes 1.34, and the version range >=1.31.0 <1.35.0 correctly ensures that v1beta1 is served only in Kubernetes versions 1.31.0 through 1.34.x, after which only the stable v1 API will be available.

Optional: Consider adding a comment for clarity.

While not critical, adding a brief comment similar to the MutatingAdmissionPolicy entry (lines 20-27) could improve maintainability by documenting the rationale for the version range and when v1beta1 can be fully removed.

Apply this diff to add an explanatory comment:

 "VolumeAttributesClass": {
+	// v1beta1 was introduced in 1.31 and v1 graduated to GA in 1.34.
+	// Serve v1beta1 only for versions <1.35.0, after which v1 is the only supported version.
 	{KubeVersionRange: semver.MustParseRange(">=1.31.0 <1.35.0"), GroupVersion: schema.GroupVersion{Group: "storage.k8s.io", Version: "v1beta1"}},
 },

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 6e00712 and 3f99c6b.

📒 Files selected for processing (1)

• pkg/operator/configobservation/apienablement/observe_runtime_config.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• pkg/operator/configobservation/apienablement/observe_runtime_config.go

[openshift-ci-robot]

@bertinatto: This pull request references Jira Issue OCPBUGS-65755, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version v1 is available in Kubernetes 1.34.

/assign @benluddy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jsafrane]

/testwith openshift/cluster-kube-apiserver-operator/master/e2e-aws-ovn openshift/kubernetes#2522

[openshift-ci]

@jsafrane, testwith: could not generate prow job. ERROR:

could not determine ci op config from metadata: got unexpected http 404 status code from configresolver: failed to get config: could not find any config for branch master on repo openshift/cluster-kube-apiserver-operator

[jsafrane]

/testwith openshift/cluster-kube-apiserver-operator/main/e2e-aws-ovn openshift/kubernetes#2522

[jsafrane]

/testwith openshift/kubernetes/master/e2e-aws-ovn-techpreview openshift/kubernetes#2522

[bertinatto]

/retest

[openshift-ci]

@bertinatto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	39b13b0	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jsafrane]

/retest-required
disruption/metrics-api connection/new should be available throughout the test

[jsafrane]

/lgtm
from storage point of view, everyone should use v1

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [benluddy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[benluddy]

/verified by CI

[openshift-ci-robot]

@benluddy: This PR has been marked as verified by CI.

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@bertinatto: Jira Issue Verification Checks: Jira Issue OCPBUGS-65755
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-65755 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Version v1 is available in Kubernetes 1.34.

/assign @benluddy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.