-
Notifications
You must be signed in to change notification settings - Fork 138
OCPBUGS-65502: manifests: Expand related objects in clusteroperator #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@tchap: This pull request references Jira Issue OCPBUGS-65502, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@tchap: This pull request references Jira Issue OCPBUGS-65502, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tchap The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| resource: "certificatesigningrequests" | ||
| - group: "rbac.authorization.k8s.io" | ||
| name: "system:openshift:operator:kube-controller-manager-operator" | ||
| resource: "clusterrolebindings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CVO will only apply these if it sees this manifest when the ClusterOperator doesn't exist. That means these won't get injected into existing clusters updating into this new code. Do you not reconcile these as part of your Go controller's ClusterOperator status management? Or does this manifest somehow also feed your Go controller? Or...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I will mark this as WIP and research it a bit more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the record into the status management as well, this should be now resolved.
Add system:openshift:operator:kube-controller-manager-operator ClusterRoleBinding to the list of related objects.
1af8214 to
2ab1905
Compare
|
@tchap: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add system:openshift:operator:kube-controller-manager-operator ClusterRoleBinding to the list of related objects.