Skip to content

[release-4.19] OCPBUGS-56527: openstack-cinder: Set --with-topology flag for node driver also #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

[release-4.19] OCPBUGS-56527: openstack-cinder: Set --with-topology flag for node driver also #384

merged 1 commit into from
May 30, 2025

Conversation

@openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #383

/assign stephenfin

@stephenfin
OCPBUGS-56128: openstack-cinder: Set --with-topology flag for node dr…
913fca3 
…iver also

Failure to do so results in the node driver reporting topology
information which the provisioner respects, preventing us attaching the
created volume.

Signed-off-by: Stephen Finucane <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 20, 2025
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-56128 has been cloned as Jira Issue OCPBUGS-56527. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-56527: openstack-cinder: Set --with-topology flag for node driver also

In response to this:

This is an automated cherry-pick of #383

/assign stephenfin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-56128: openstack-cinder: Set --with-topology flag for node driver also [release-4.19] OCPBUGS-56527: openstack-cinder: Set --with-topology flag for node driver also May 20, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 20, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56527, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-56128 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-56128 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #383

/assign stephenfin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from EmilienM and gnufied May 20, 2025 20:23
@stephenfin
Copy link
Contributor

/test e2e-openstack-cinder-csi

@gnufied
Copy link
Member

gnufied commented May 29, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025
@eurijon
Copy link

eurijon commented May 29, 2025

/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2025

@eurijon: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2025 •
edited
Loading

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 913fca3 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@itzikb-redhat
Copy link

/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2025

@itzikb-redhat: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stephenfin
Copy link
Contributor

/test e2e-openstack-cinder-csi

@stephenfin
Copy link
Contributor

Another timing-related (and unrelated to this PR) failure

@duanwei33
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 30, 2025
@stephenfin
Copy link
Contributor

/label backport-risk-assessed

I suspect only @mandre (who is out today) can set this from our end. Here's goes nothing 🤷

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2025

@stephenfin: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/label backport-risk-assessed

I suspect only @mandre (who is out today) can set this from our end. Here's goes nothing 🤷

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stephenfin
Copy link
Contributor

stephenfin commented May 30, 2025 •
edited
Loading

/label backport-risk-assessed

I suspect only @mandre (who is out today) can set this from our end. Here's goes nothing 🤷

Actually, no, I need @gnufied or @jsafrane (I should have guessed as much).

Also, that error message is very unhelpful. I'm working on it.

@stephenfin stephenfin mentioned this pull request May 30, 2025
Open
@gnufied
Copy link
Member

gnufied commented May 30, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit b61e357 into openshift:release-4.19 May 30, 2025
22 of 23 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-56527: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-56527 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #383

/assign stephenfin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: azure-file-csi-driver-operator
This PR has been included in build ose-azure-file-csi-driver-operator-container-v4.19.0-202505301615.p0.gb61e357.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-efs-csi-driver-operator
This PR has been included in build ose-aws-efs-csi-driver-operator-container-v4.19.0-202505301615.p0.gb61e357.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: csi-driver-manila-operator
This PR has been included in build csi-driver-manila-operator-container-v4.19.0-202505301615.p0.gb61e357.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-ebs-csi-driver-operator
This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.19.0-202505301615.p0.gb61e357.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-azure-disk-csi-driver-operator
This PR has been included in build ose-azure-disk-csi-driver-operator-container-v4.19.0-202505301615.p0.gb61e357.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-smb-csi-driver-operator
This PR has been included in build ose-smb-csi-driver-operator-container-v4.19.0-202505301615.p0.gb61e357.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-openstack-cinder-csi-driver-operator
This PR has been included in build ose-openstack-cinder-csi-driver-operator-container-v4.19.0-202505301615.p0.gb61e357.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-06-03-070127

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-06-02-200358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@gnufied gnufied

@stephenfin stephenfin

@chao007 chao007

@duanwei33 duanwei33

@ropatil010 ropatil010

@Phaow Phaow

@radeore radeore

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.