Ocpedge 2217 add fencing hostconfig #10071
Draft
+523
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh on them for Two Nodes with Fencing topology
This function can now be used for both: - controlPlane.fencing.credentials validation (install-config) - platform.baremetal.hosts[].bmc validation (agent hostconfig generation)
- Add generateFencingCredentialsYAML() helper to convert BMC to YAML - Extend HostConfigFiles() to generate fencing-credentials.yaml per host - Convert BMC.DisableCertificateVerification (bool) to certificateVerification (string) - Only generate file if BMC address is configured
Tests cover: - generateFencingCredentialsYAML() with various BMC configurations - Certificate verification enabled/disabled conversion - HostConfigFiles() with BMC configured hosts - HostConfigFiles() without BMC (worker nodes) - Multiple hosts with mixed BMC configurations
The validation now correctly rejects IPMI addresses and only accepts RedFish-compatible BMC addresses. Updated c1(), c2(), c3() test helpers to use redfish+https:// scheme instead of ipmi://
Validates that baremetal host BMC addresses are RedFish-compatible for Two-Node Fencing (TNF) clusters. This ensures both sources of fencing credentials are validated: 1. controlPlane.fencing.credentials[] - for cluster-etcd-operator 2. platform.baremetal.hosts[].bmc - for host provisioning and ABI The validation only applies to TNF clusters (2 control plane replicas with fencing enabled) and only validates master/control plane nodes. Added comprehensive tests covering: - Valid RedFish BMC addresses - Invalid IPMI addresses (should fail) - Non-TNF clusters (should not validate) - Worker nodes (can use IPMI)
…remetal.hosts[].bmc This PR focuses exclusively on validating baremetal.hosts[].bmc addresses for TNF (Two-Node Fencing) clusters. Validation of controlPlane.fencing.credentials will be handled in a separate PR. Changes: - Remove validateRedfishURL() and validateFencingCredentialAddress() from installconfig.go - Remove call to validateFencingCredentialAddress() in validateFencingCredentials() - Keep all baremetal BMC validation in pkg/types/baremetal/validation/platform.go The baremetal validation package has its own validateBMCAddressForFencing() implementation to avoid import cycles.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
Move RedFish BMC address validation to pkg/types/common to be shared between: - controlPlane.fencing.credentials validation (future use) - platform.baremetal.hosts[].bmc validation (for TNF clusters) This avoids import cycles and provides a single source of truth for RedFish BMC address validation, including: - URL format validation - RedFish protocol requirement (IPMI not supported) - Port validation (explicit or inferred from https/http scheme) Updated baremetal validation to use the shared function instead of a local implementation, ensuring consistent validation across the codebase.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.