Skip to content

Conversation

@jinyunma
Copy link
Contributor

In the previous PR #10065, the update is not enough, and missed one old property to be updated.
PR installer#10065 has been backported to 4.19 (but 4.19 PR is not merged yet), so this PR only need to be backported to 4.20, then will do manual backport to 4.19.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 17, 2025
@openshift-ci-robot
Copy link
Contributor

@jinyunma: This pull request references Jira Issue OCPBUGS-65661, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In the previous PR #10065, the update is not enough, and missed one old property to be updated.
PR installer#10065 has been backported to 4.19 (but 4.19 PR is not merged yet), so this PR only need to be backported to 4.20, then will do manual backport to 4.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jinyunma
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 17, 2025
@openshift-ci-robot
Copy link
Contributor

@jinyunma: This pull request references Jira Issue OCPBUGS-65661, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 17, 2025
@openshift-ci openshift-ci bot requested review from gpei, jhixson74 and rna-afk November 17, 2025 09:49
@jhixson74
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2025
@jinyunma jinyunma changed the title OCPBUGS-65661: continue to udpate 02_storage.json using new property storageAccountId OCPBUGS-65661: continue to update 02_storage.json using new property storageAccountId Nov 18, 2025
@jinyunma
Copy link
Contributor Author

/retest-required

@jinyunma
Copy link
Contributor Author

/test e2e-azure-ovn-upi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@jinyunma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-upi 5c4521e link false /test e2e-azurestack-upi
ci/prow/e2e-azure-ovn-upi 5c4521e link false /test e2e-azure-ovn-upi
ci/prow/e2e-azure-ovn-shared-vpc 5c4521e link false /test e2e-azure-ovn-shared-vpc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2025
@jinyunma
Copy link
Contributor Author

/verified by e2e-azure-ovn-upi

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 19, 2025
@openshift-ci-robot
Copy link
Contributor

@jinyunma: This PR has been marked as verified by [e2e-azure-ovn-upi](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/10089/pull-ci-openshift-installer-main-e2e-azure-ovn-upi/1990617413007183872).

In response to this:

/verified by e2e-azure-ovn-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 1dacae5 into openshift:main Nov 19, 2025
15 of 21 checks passed
@openshift-ci-robot
Copy link
Contributor

@jinyunma: Jira Issue Verification Checks: Jira Issue OCPBUGS-65661
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-65661 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

In the previous PR #10065, the update is not enough, and missed one old property to be updated.
PR installer#10065 has been backported to 4.19 (but 4.19 PR is not merged yet), so this PR only need to be backported to 4.20, then will do manual backport to 4.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jinyunma
Copy link
Contributor Author

/cherry-pick release-4.20

@jinyunma jinyunma deleted the OCPBUGS-65661-fix branch November 19, 2025 05:27
@openshift-cherrypick-robot

@jinyunma: new pull request created: #10103

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.21.0-0.nightly-2025-11-22-193140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants