Skip to content

MULTIARCH-5553: PowerVS: Introduce group division #10095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+177 −3
Open

MULTIARCH-5553: PowerVS: Introduce group division #10095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pkg/asset/manifests/powervs/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func GenerateClusterAssets(installConfig *installconfig.InstallConfig, clusterID
return nil, fmt.Errorf("generateClusterAssets could not handle vpc")
}
}

vpcSecurityGroups := getVPCSecurityGroups(clusterID.InfraID)
// The Transit Gateway can be either:
// 1) blank - CAPI will create one for us.
// 2) an id of an existing TG.
Expand Down Expand Up @@ -192,8 +192,9 @@ func GenerateClusterAssets(installConfig *installconfig.InstallConfig, clusterID
ResourceGroup: &capibm.IBMPowerVSResourceReference{
Name: &installConfig.Config.Platform.PowerVS.PowerVSResourceGroup,
},
VPC: vpcResourceRef,
TransitGateway: transitGateway,
VPC: vpcResourceRef,
VPCSecurityGroups: vpcSecurityGroups,
TransitGateway: transitGateway,
LoadBalancers: []capibm.VPCLoadBalancerSpec{
{
Name: fmt.Sprintf("%s-loadbalancer", clusterID.InfraID),
Expand Down
173 changes: 173 additions & 0 deletions pkg/asset/manifests/powervs/securitygroups.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,173 @@
package powervs

import (
"fmt"

"k8s.io/utils/ptr"
capibmcloud "sigs.k8s.io/cluster-api-provider-ibmcloud/api/v1beta2"
)

const (
controlPlaneSGNameSuffix = "sg-control-plane"
clusterWideSGNameSuffix = "sg-cluster-wide"
kubeAPILBSGNameSuffix = "sg-kube-api-lb"
)

func buildControlPlaneSecurityGroup(infraID string) capibmcloud.VPCSecurityGroup {
kubeAPILBSGNamePtr := ptr.To(fmt.Sprintf("%s-%s", infraID, controlPlaneSGNameSuffix))
return capibmcloud.VPCSecurityGroup{
Name: kubeAPILBSGNamePtr,
Rules: []*capibmcloud.VPCSecurityGroupRule{
{
Action: capibmcloud.VPCSecurityGroupRuleActionAllow,
Direction: capibmcloud.VPCSecurityGroupRuleDirectionInbound,
Source: &capibmcloud.VPCSecurityGroupRulePrototype{
PortRange: &capibmcloud.VPCSecurityGroupPortRange{
MaximumPort: 10258,
MinimumPort: 10258,
},
Protocol: capibmcloud.VPCSecurityGroupRuleProtocolTCP,
Remotes: []capibmcloud.VPCSecurityGroupRuleRemote{
{
RemoteType: capibmcloud.VPCSecurityGroupRuleRemoteTypeAny,
},
},
},
},
{
Action: capibmcloud.VPCSecurityGroupRuleActionAllow,
Direction: capibmcloud.VPCSecurityGroupRuleDirectionInbound,
Source: &capibmcloud.VPCSecurityGroupRulePrototype{
PortRange: &capibmcloud.VPCSecurityGroupPortRange{
MaximumPort: 22623,
MinimumPort: 22623,
},
Protocol: capibmcloud.VPCSecurityGroupRuleProtocolTCP,
Remotes: []capibmcloud.VPCSecurityGroupRuleRemote{
{
RemoteType: capibmcloud.VPCSecurityGroupRuleRemoteTypeAny,
},
},
},
},
{
Action: capibmcloud.VPCSecurityGroupRuleActionAllow,
Direction: capibmcloud.VPCSecurityGroupRuleDirectionInbound,
Source: &capibmcloud.VPCSecurityGroupRulePrototype{
PortRange: &capibmcloud.VPCSecurityGroupPortRange{
MaximumPort: 443,
MinimumPort: 443,
},
Protocol: capibmcloud.VPCSecurityGroupRuleProtocolTCP,
Remotes: []capibmcloud.VPCSecurityGroupRuleRemote{
{
RemoteType: capibmcloud.VPCSecurityGroupRuleRemoteTypeAny,
},
},
},
},
},
}
}

func buildKubeAPILBSecurityGroup(infraID string) capibmcloud.VPCSecurityGroup {
kubeAPILBSGNamePtr := ptr.To(fmt.Sprintf("%s-%s", infraID, kubeAPILBSGNameSuffix))
return capibmcloud.VPCSecurityGroup{
Name: kubeAPILBSGNamePtr,
Rules: []*capibmcloud.VPCSecurityGroupRule{
{
Action: capibmcloud.VPCSecurityGroupRuleActionAllow,
Direction: capibmcloud.VPCSecurityGroupRuleDirectionInbound,
Source: &capibmcloud.VPCSecurityGroupRulePrototype{
PortRange: &capibmcloud.VPCSecurityGroupPortRange{
MaximumPort: 6443,
MinimumPort: 6443,
},
Protocol: capibmcloud.VPCSecurityGroupRuleProtocolTCP,
Remotes: []capibmcloud.VPCSecurityGroupRuleRemote{
{
RemoteType: capibmcloud.VPCSecurityGroupRuleRemoteTypeAny,
},
},
},
},
},
}
}

func buildClusterWideSecurityGroup(infraID string) capibmcloud.VPCSecurityGroup {
kubeAPILBSGNamePtr := ptr.To(fmt.Sprintf("%s-%s", infraID, clusterWideSGNameSuffix))
return capibmcloud.VPCSecurityGroup{
Name: kubeAPILBSGNamePtr,
Rules: []*capibmcloud.VPCSecurityGroupRule{
{
// SSH inbound
Action: capibmcloud.VPCSecurityGroupRuleActionAllow,
Direction: capibmcloud.VPCSecurityGroupRuleDirectionInbound,
Source: &capibmcloud.VPCSecurityGroupRulePrototype{
PortRange: &capibmcloud.VPCSecurityGroupPortRange{
MaximumPort: 22,
MinimumPort: 22,
},
Protocol: capibmcloud.VPCSecurityGroupRuleProtocolTCP,
Remotes: []capibmcloud.VPCSecurityGroupRuleRemote{
{
RemoteType: capibmcloud.VPCSecurityGroupRuleRemoteTypeAny,
},
},
},
},
{
Action: capibmcloud.VPCSecurityGroupRuleActionAllow,
Direction: capibmcloud.VPCSecurityGroupRuleDirectionInbound,
Source: &capibmcloud.VPCSecurityGroupRulePrototype{
PortRange: &capibmcloud.VPCSecurityGroupPortRange{
MaximumPort: 5000,
MinimumPort: 5000,
},
Protocol: capibmcloud.VPCSecurityGroupRuleProtocolTCP,
Remotes: []capibmcloud.VPCSecurityGroupRuleRemote{
{
RemoteType: capibmcloud.VPCSecurityGroupRuleRemoteTypeAny,
},
},
},
},
{
// ping
Action: capibmcloud.VPCSecurityGroupRuleActionAllow,
Direction: capibmcloud.VPCSecurityGroupRuleDirectionInbound,
Source: &capibmcloud.VPCSecurityGroupRulePrototype{
Protocol: capibmcloud.VPCSecurityGroupRuleProtocolIcmp,
Remotes: []capibmcloud.VPCSecurityGroupRuleRemote{
{
RemoteType: capibmcloud.VPCSecurityGroupRuleRemoteTypeAny,
},
},
},
},
{
// Outbound for cluster-wide
Action: capibmcloud.VPCSecurityGroupRuleActionAllow,
Destination: &capibmcloud.VPCSecurityGroupRulePrototype{
Protocol: capibmcloud.VPCSecurityGroupRuleProtocolAll,
Remotes: []capibmcloud.VPCSecurityGroupRuleRemote{
{
RemoteType: capibmcloud.VPCSecurityGroupRuleRemoteTypeAny,
},
},
},
Direction: capibmcloud.VPCSecurityGroupRuleDirectionOutbound,
},
},
}
}

func getVPCSecurityGroups(infraID string) []capibmcloud.VPCSecurityGroup {
// IBM Power VS will rely on 3 SecurityGroups to manage traffic.
securityGroups := make([]capibmcloud.VPCSecurityGroup, 0, 3)
securityGroups = append(securityGroups, buildClusterWideSecurityGroup(infraID))
securityGroups = append(securityGroups, buildControlPlaneSecurityGroup(infraID))
securityGroups = append(securityGroups, buildKubeAPILBSecurityGroup(infraID))
return securityGroups
}