Skip to content

SPLAT-2328: Update vsphere vm-host zonal e2e logging #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SPLAT-2328: Update vsphere vm-host zonal e2e logging #1389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/e2e/vsphere/hostzonal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,10 @@ func failIfMachineIsNotInCorrectRegionZone(ctx context.Context,
}
}

if !foundRegion || !foundZone {
Expect(fmt.Errorf("node %s missing expected region '%s' or zone '%s' tags", n.Name, fd.Region, fd.Zone)).NotTo(HaveOccurred())
}
By(fmt.Sprintf("Node %s (VM: %s) - Region: %s (found: %t), Zone: %s (found: %t)",
n.Name, vm.Name(), fd.Region, foundRegion, fd.Zone, foundZone))

Expect(foundRegion && foundZone).To(BeTrue(), "expected vm to be in the correct region and zone")
}
}
}
Expand Down Expand Up @@ -293,9 +294,8 @@ func failIfMachineIsNotInCorrectVMGroup(ctx context.Context,
}

for moRef, v := range foundMoRef {
if !v {
Expect(fmt.Errorf("virtual machine id %s was not in vm group %s", moRef, fd.ZoneAffinity.HostGroup.VMGroup)).NotTo(HaveOccurred())
}
By(fmt.Sprintf("managed object reference %s, vm group %s", moRef, fd.ZoneAffinity.HostGroup.VMGroup))
Expect(v).To(BeTrue(), "expected to find node in vm group")
}
}
}
Expand Down