MCO-1961: Add the OSImageStream Controller #5457
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pablintino: This pull request references MCO-1961 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
pablintino
force-pushed
the
mco-1961-osimagestream-controller
branch
2 times, most recently
from
c3314f8 to
a565e57
Compare
|
Changes LGTM |
This change adds the OSImageStream controller and the additional logic required to introduce OSImageStreams into the MCO.
pablintino
force-pushed
the
mco-1961-osimagestream-controller
branch
from
a565e57 to
c2e23bb
Compare
isabella-janssen
left a comment
isabella-janssen
left a comment
There was a problem hiding this comment.
/lgtm
These changes looks clear to me & make sense. The new unit tests seem to cover the added functionality well & are passing.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-hypershift |
1 similar comment
|
/test e2e-hypershift |
|
This shouldn't affect hypershift since the controller doesn't run /override ci/prow/e2e-hypershift |
|
@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-hypershift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pablintino: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @pablintino |
openshift-ci-robot
added
the
verified
|
@pablintino: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit 8649284
into
openshift:main
5 participants
- What I did
This change adds the OSImageStream controller and the additional logic required to introduce OSImageStreams into the MCO.
- How to verify it
Self-verified by the associated UTs.
- Description for the changelog
This change adds the OSImageStream controller and the additional logic required to introduce OSImageStreams into the MCO.