-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[OBSDOCS-2663] Modify access key secret and bucket name in docs #101390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: standalone-logging-docs-main
Are you sure you want to change the base?
[OBSDOCS-2663] Modify access key secret and bucket name in docs #101390
Conversation
AWS secret code needs to be corrected Here is the documentation link: https://docs.redhat.com/en/documentation/red_hat_openshift_logging/6.3/html/installing_logging/installing-logging#install-loki-operator-cli_installing-logging:~:text=Create%20a%20secret%20with%20the%20credentials%20to%20access%20the%20object%20storage.%20For%20example%2C%20create%20a%20secret%20to%20access%20Amazon%20Web%20Services%20(AWS)%20s3. Here is the current look: 9. Create a secret with the credentials to access the object storage. For example, create a secret to access Amazon Web Services (AWS) s3. apiVersion: v1 kind: Secret metadata: name: logging-loki-s3 1 namespace: openshift-logging stringData: 2 access_key_id: <access_key_id> access_key_secret: <access_secret> bucketnames: s3-bucket-name endpoint: https://s3.eu-central-1.amazonaws.com region: eu-central-1 `access_key_secret` value is wrongly mentioned. It needs to be corrected. The correct value is `access_key_secret` Here is the updated look: 9. Create a secret with the credentials to access the object storage. For example, create a secret to access Amazon Web Services (AWS) s3. apiVersion: v1 kind: Secret metadata: name: logging-loki-s3 1 namespace: openshift-logging stringData: 2 access_key_id: <access_key_id> access_key_secret: <secret_access_key> bucketnames: <s3_bucket_name> endpoint: https://s3.eu-central-1.amazonaws.com region: eu-central-1
|
🤖 Wed Oct 29 22:49:57 - Prow CI generated the docs preview: https://101390--ocpdocs-pr.netlify.app/openshift-logging/latest/installing/installing-logging.html |
|
@prithvipatil97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hello Team, All checks have passed, and I have reviewed the PR with the peer review checklist. @anpingli , @QiaolingTang , it would be really helpful if someone could please take a look and provide QE approval for this change. Thanks in advance. Regards, |
|
/lgtm |
|
Hello Anping Li, Regards, |
|
/label merge-review-needed |
https://docs.redhat.com/en/documentation/red_hat_openshift_logging/6.3/html/installing_logging/installing-logging#install-loki-operator-cli_installing-logging:~:text=Create%20a%20secret%20with%20the%20credentials%20to%20access%20the%20object%20storage.%20For%20example%2C%20create%20a%20secret%20to%20access%20Amazon%20Web%20Services%20(AWS)%20s3.
Here is the current look:
access_key_secretvalue is wrongly mentioned.secret_access_key<s3_bucket_name>.Here is the updated look:
Version(s):
Logging 6.4, Logging 6.3, Logging 6.2, Logging 6.1, Logging 6.0
Issue:
https://issues.redhat.com/browse/OBSDOCS-2663
Link to docs preview:
https://101390--ocpdocs-pr.netlify.app/openshift-logging/latest/installing/installing-logging.html
QE review:
Additional information: