-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Hcp #91078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Hcp #91078
Conversation
Changes to be committed: modified: modules/installation-user-provisioned-validating-dns.adoc In the example of DNS configuration for user-provisioned clusters: https://docs.openshift.com/container-platform/4.14/installing/installing_vsphere/installing-vsphere.html#installation-dns-user-infra-example_installing-vsphere The TTL value is 1w, according to that the output of dig command should be "604800" Sample DNS zone database: ``` $TTL 1W @ IN SOA ns1.example.com. root ( 2019070700 ; serial 3H ; refresh (3 hours) 30M ; retry (30 minutes) 2W ; expiry (2 weeks) 1W ) ; minimum (1 week) IN NS ns1.example.com. IN MX 10 smtp.example.com. ... ... ``` Sample DNS zone database for reverse records: ``` $TTL 1W @ IN SOA ns1.example.com. root ( 2019070700 ; serial 3H ; refresh (3 hours) 30M ; retry (30 minutes) 2W ; expiry (2 weeks) 1W ) ; minimum (1 week) IN NS ns1.example.com. ``` This is incorrect value: ``` $ dig +noall +answer @<nameserver_ip> api.<cluster_name>.<base_domain> api.ocp4.example.com. 0 IN A 192.168.1.5 ``` The correct value according to TTL 1w ``` $ dig +noall +answer @<nameserver_ip> api.<cluster_name>.<base_domain> api.ocp4.example.com. 604800 IN A 192.168.1.5 ```
Update installation-user-provisioned-validating-dns.adoc
Fixed the ocp version info Version(s): 4.15 Issue: Ensure that the Bare Metal Operator is available: .Example output [source,terminal,subs="attributes+"] ---- NAME VERSION AVAILABLE PROGRESSING DEGRADED SINCE MESSAGE baremetal {product-version} True False False 3d15h ---- https://docs.openshift.com/container-platform/4.14/installing/installing_bare_metal_ipi/ipi-install-expanding-the-cluster.html#replacing-a-bare-metal-control-plane-node_ipi-install-expanding QE review: [ ] QE has approved this change. .Example output [source,terminal,subs="attributes+"] ---- NAME VERSION AVAILABLE PROGRESSING DEGRADED SINCE MESSAGE baremetal {product-version} True False False 3d15h ----
In this section: https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/hosted_control_planes/hosted-control-planes-overview#web-console_hcp-overview:~:text=You%20configure%20etcd%20encryption%20by%20using%20the%20APIServer%20resource%20with%20AES%2DGCM%20or%20AES%2DCBC.%20For%20more%20information%2C%20see%20%22Enabling%20etcd%20encryption%22. Hyperlink was missing, which I added correctly in this PR.
Hi @BabbarPB08. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hello @kowen-rh, My friend, could you please check this? |
🤖 Wed Apr 02 16:13:15 - Prow CI generated the docs preview: https://91078--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/index.html |
Closing in favor of #91526 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a suggestion and an overall comment on the change. Also, be sure to squash your commits down to 1 before you submit this for merging. Thanks!
Suggested by Laura Co-authored-by: Laura Hinson <[email protected]>
/label peer-review-needed |
@BabbarPB08: Can not set label peer-review-needed: Must be member in one of these teams: [team-red-hat] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@BabbarPB08: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
A few things: In the past we've shied away from saying ". . . in the Additional resources section." @bergerhoffer wdyt? The commits need squashed before we can merge this PR. |
Yep! We have some guidance now about avoiding this: https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#lead-in-link-sentence-style-for-non-xref-situations
|
The This is because your PR targets the If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Version(s): 4.14+
Issue: https://issues.redhat.com/browse/OCPBUGS-54227
Link to docs preview: https://91078--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/index.html#etcd-encryption_hcp-overview
QE review:
QE not required for this change. No technical content changes in this PR.
Additional information:
In this HCP comparison with OCP etcd I found that the hyperlink was missing, which I added in this PR