Skip to content

Conversation

BabbarPB08
Copy link
Contributor

@BabbarPB08 BabbarPB08 commented Mar 25, 2025

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/OCPBUGS-54227

Link to docs preview: https://91078--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/index.html#etcd-encryption_hcp-overview

QE review:

QE not required for this change. No technical content changes in this PR.

Additional information:
In this HCP comparison with OCP etcd I found that the hyperlink was missing, which I added in this PR

 Changes to be committed:
        modified:   modules/installation-user-provisioned-validating-dns.adoc


In the example of DNS configuration for user-provisioned clusters:

https://docs.openshift.com/container-platform/4.14/installing/installing_vsphere/installing-vsphere.html#installation-dns-user-infra-example_installing-vsphere


The TTL value is 1w, according to that the output of dig command should be "604800"



Sample DNS zone database:
```
$TTL 1W
@       IN      SOA     ns1.example.com.        root (
                        2019070700      ; serial
                        3H              ; refresh (3 hours)
                        30M             ; retry (30 minutes)
                        2W              ; expiry (2 weeks)
                        1W )            ; minimum (1 week)
        IN      NS      ns1.example.com.
        IN      MX 10   smtp.example.com.
...
...
```

Sample DNS zone database for reverse records:
```
$TTL 1W
@       IN      SOA     ns1.example.com.        root (
                        2019070700      ; serial
                        3H              ; refresh (3 hours)
                        30M             ; retry (30 minutes)
                        2W              ; expiry (2 weeks)
                        1W )            ; minimum (1 week)
        IN      NS      ns1.example.com.
```



This is incorrect value:
```
$ dig +noall +answer @<nameserver_ip> api.<cluster_name>.<base_domain>
api.ocp4.example.com.           0       IN      A       192.168.1.5
```

The correct value according to TTL 1w
```
$ dig +noall +answer @<nameserver_ip> api.<cluster_name>.<base_domain>
api.ocp4.example.com.           604800       IN      A       192.168.1.5
```
Update installation-user-provisioned-validating-dns.adoc
Fixed the ocp version info

Version(s):
4.15

Issue:
Ensure that the Bare Metal Operator is available:

.Example output
[source,terminal,subs="attributes+"]
----
NAME        VERSION   AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
baremetal   {product-version}   True        False         False      3d15h
----

https://docs.openshift.com/container-platform/4.14/installing/installing_bare_metal_ipi/ipi-install-expanding-the-cluster.html#replacing-a-bare-metal-control-plane-node_ipi-install-expanding

QE review:

[ ] QE has approved this change.

.Example output
[source,terminal,subs="attributes+"]
----
NAME        VERSION   AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
baremetal   {product-version}   True        False         False      3d15h
----
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 25, 2025
Copy link

openshift-ci bot commented Mar 25, 2025

Hi @BabbarPB08. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BabbarPB08
Copy link
Contributor Author

Hello @kowen-rh,

My friend, could you please check this?

@lahinson lahinson added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2025
@lahinson lahinson self-assigned this Apr 2, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 2, 2025

🤖 Wed Apr 02 16:13:15 - Prow CI generated the docs preview:

https://91078--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/index.html

@lahinson
Copy link
Contributor

lahinson commented Apr 2, 2025

Closing in favor of #91526

@lahinson lahinson closed this Apr 2, 2025
@lahinson lahinson reopened this Apr 2, 2025
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a suggestion and an overall comment on the change. Also, be sure to squash your commits down to 1 before you submit this for merging. Thanks!

Suggested by Laura

Co-authored-by: Laura Hinson <[email protected]>
@BabbarPB08
Copy link
Contributor Author

/label peer-review-needed

Copy link

openshift-ci bot commented Apr 2, 2025

@BabbarPB08: Can not set label peer-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Apr 2, 2025

@BabbarPB08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lahinson lahinson added this to the Continuous Release milestone Apr 2, 2025
@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 2, 2025
@stevsmit
Copy link
Member

stevsmit commented Apr 2, 2025

A few things:

In the past we've shied away from saying ". . . in the Additional resources section." @bergerhoffer wdyt?

The commits need squashed before we can merge this PR.

@stevsmit stevsmit removed the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 2, 2025
@bergerhoffer
Copy link
Contributor

In the past we've shied away from saying ". . . in the Additional resources section." @bergerhoffer wdyt?

Yep! We have some guidance now about avoiding this: https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#lead-in-link-sentence-style-for-non-xref-situations

Do not state "in the Additional resources section" or other variants. Mentioning the <section_name> is enough to prompt a documentation user to find the section in the same document.

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants