OSDOCS-15427: Completed CQA for Deploying HCP on IBM Power #98081
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
dfitzmau
force-pushed
the
OSDOCS-15427
branch
3 times, most recently
from
a21340b to
1f722c9
Compare
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
size/L
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
dfitzmau
force-pushed
the
OSDOCS-15427
branch
3 times, most recently
from
17edfc0 to
156960e
Compare
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
dfitzmau
force-pushed
the
OSDOCS-15427
branch
3 times, most recently
from
03abda4 to
0fe44c6
Compare
dfitzmau
force-pushed
the
OSDOCS-15427
branch
2 times, most recently
from
e7e5576 to
6f9e8cb
Compare
dfitzmau
force-pushed
the
OSDOCS-15427
branch
2 times, most recently
from
b72a5a0 to
02edd22
Compare
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
dfitzmau
force-pushed
the
OSDOCS-15427
branch
from
02edd22 to
dc7e465
Compare
|
@dfitzmau: This pull request references OSDOCS-15427 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
dfitzmau
added
the
merge-review-needed
lahinson
added
merge-review-in-progress
There was a problem hiding this comment.
@dfitzmau Thank you for these good and necessary quality improvements! I caught one typo, had one question for you related to passive voice, and most importantly, I had one comment about the hcp-bm-hc.adoc file. PTAL when you can, and let me know if you'd like to chat about any of my comments.
There was a problem hiding this comment.
Hi @dfitzmau - You might not be aware of this, but this module is also used in the "Deploying HCP on bare metal" and "Deploying HCP on IBM Z" sections. As I've been reviewing the changes here, I'm concerned that some of the changes -- which make sense in the context of the IBM Power section -- won't work as well in the context of the bare metal or IBM Z sections. With that in mind, I'd suggest renaming this module to something like hcp-ibm-power-hc, and updating the assembly to point to the new module. If you'd like to chat about this, let me know.
| ==== | ||
|
|
||
| If you remove the `kubeAPIServerDNSName` field from the specification for the `HostedCluster` object, all newly generated secrets and the `CustomKubeconfig` reference are removed from the cluster and from the `status` field. | ||
| If you remove the `kubeAPIServerDNSName` parameter from the specification for the `HostedCluster` object, removal of all newly generated secrets and the `CustomKubeconfig` reference happen from the cluster and from the `status` parameter. |
There was a problem hiding this comment.
I know we generally advise using active voice instead of passive, but sometimes passive voice simply works better in technical content, especially in cases where a subject isn't clear, as it is here where "something" is removing secrets and the CustomKubeconfig reference.
I find this phrase:
"...all newly generated secrets and the CustomKubeconfig reference are removed from the cluster and from the status parameter"
to be more natural than this one:
"...removal of all newly generated secrets and the CustomKubeconfig reference happen from the cluster and from the status parameter"
The revised version also makes it harder to determine where the secrets and reference are being removed from.
I'll leave it to you as to what wording to use, but I did want to mention this, as I stumbled a bit when I read the revision.
| You can create heterogeneous node pools on the agent platform. The platform enables clusters to run diverse machine types, such as `x86_64` or `ppc64le`, within a single hosted cluster. | ||
|
|
||
| To create a heterogeneous node pool, perform the following general steps, as described in the following sections: | ||
| Creating a heterogeneous node pool requirs completion of the following general steps: |
There was a problem hiding this comment.
| Creating a heterogeneous node pool requirs completion of the following general steps: | |
| Creating a heterogeneous node pool requires completion of the following general steps: |
Admin tasks only?
Version(s):
4.17+
Issue:
OSDOCS-15427
Link to docs preview:
IBM Power
grep '^include::modules/' .adoc |
sed -E 's|include::modules/([^[]+)[.*|\1|' > output.txt