Skip to content

Conversation

ormergi
Copy link
Contributor

@ormergi ormergi commented Sep 29, 2025

This PR is a followup PR to #30010 #30197, adding tests to check MAC conflict detection:
create VM with Preconfigured MAC, assert MAC conflict are detected

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2025
Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ormergi ormergi changed the title ovn-k, virt, preconfigured udn addresses: Test MAC conflict detection CORENET-6373: ovn-k, virt, preconfigured udn addresses: Test MAC conflict detection Sep 29, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2025

@ormergi: This pull request references CORENET-6373 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead.

In response to this:

Rebased on #30197 (first 3 commits)

This PR is a followup PR to #30010 #30197, adding tests to check MAC conflict detection:
create VM with Preconfigured MAC, assert MAC conflict are detected

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ormergi
Copy link
Contributor Author

ormergi commented Sep 29, 2025

/tide refresh

@ormergi ormergi force-pushed the preconfigured-udn-addresses-e2e-mac-conflict-detection branch from d1b63ed to 77b39ed Compare September 29, 2025 15:08
@ormergi
Copy link
Contributor Author

ormergi commented Sep 29, 2025

/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview

@ormergi
Copy link
Contributor Author

ormergi commented Sep 29, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/ovn-kubernetes#2769

@ormergi ormergi force-pushed the preconfigured-udn-addresses-e2e-mac-conflict-detection branch from 77b39ed to 7076438 Compare September 30, 2025 08:38
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2025
@ormergi
Copy link
Contributor Author

ormergi commented Sep 30, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/ovn-kubernetes#2769

@ormergi
Copy link
Contributor Author

ormergi commented Sep 30, 2025

Previous job fail to start

@ormergi
Copy link
Contributor Author

ormergi commented Sep 30, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/ovn-kubernetes#2769

@ormergi ormergi force-pushed the preconfigured-udn-addresses-e2e-mac-conflict-detection branch from 7076438 to 94383a7 Compare October 1, 2025 09:01
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2025
@ormergi ormergi force-pushed the preconfigured-udn-addresses-e2e-mac-conflict-detection branch from 94383a7 to c7dbb14 Compare October 1, 2025 09:03
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2025
@ormergi
Copy link
Contributor Author

ormergi commented Oct 1, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/ovn-kubernetes#2769

@ormergi
Copy link
Contributor Author

ormergi commented Oct 3, 2025

@maiqueb / @qinqon could you please have a look?

@ormergi ormergi marked this pull request as ready for review October 3, 2025 06:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2025
@openshift-ci openshift-ci bot requested review from miheer and pperiyasamy October 3, 2025 06:15
@ormergi
Copy link
Contributor Author

ormergi commented Oct 5, 2025

/cc @maiqueb

@openshift-ci openshift-ci bot requested a review from maiqueb October 5, 2025 07:43
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2025
@ormergi ormergi force-pushed the preconfigured-udn-addresses-e2e-mac-conflict-detection branch from c7dbb14 to 3c99d89 Compare October 16, 2025 08:12
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 16, 2025

@ormergi: This pull request references CORENET-6373 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead.

In response to this:

Rebased on #30197 (first 3 commits)

This PR is a followup PR to #30010 #30197, adding tests to check MAC conflict detection:
create VM with Preconfigured MAC, assert MAC conflict are detected

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ormergi
Copy link
Contributor Author

ormergi commented Oct 16, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/ovn-kubernetes#2769

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2025
@ormergi
Copy link
Contributor Author

ormergi commented Oct 16, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/ovn-kubernetes#2798

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 16, 2025

@ormergi: This pull request references CORENET-6373 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead.

In response to this:

This PR is a followup PR to #30010 #30197, adding tests to check MAC conflict detection:
create VM with Preconfigured MAC, assert MAC conflict are detected

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Verify KubeVirt VMs with preconfigured MAC address retain a
requested MAC address before and after another VM is created
requesting the same MAC address.
And verify the other VM requesting the same MAC address get
the appropriate address conflict error event.

Signed-off-by: Or Mergi <[email protected]>
@ormergi ormergi force-pushed the preconfigured-udn-addresses-e2e-mac-conflict-detection branch from 3c99d89 to 0c58f2a Compare October 19, 2025 07:02
@ormergi
Copy link
Contributor Author

ormergi commented Oct 19, 2025

/test openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview

Copy link
Contributor

openshift-ci bot commented Oct 19, 2025

@ormergi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-csi
/test e2e-aws-jenkins
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-image-registry
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-builds
/test e2e-gcp-ovn-image-ecosystem
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test go-verify-deps
/test images
/test lint
/test okd-scos-images
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-agnostic-ovn-cmd
/test e2e-aws-disruptive
/test e2e-aws-etcd-certrotation
/test e2e-aws-etcd-recovery
/test e2e-aws-ovn
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-etcd-scaling
/test e2e-aws-ovn-kube-apiserver-rollout
/test e2e-aws-ovn-kubevirt
/test e2e-aws-ovn-serial-fast
/test e2e-aws-ovn-serial-ipsec
/test e2e-aws-ovn-serial-publicnet-1of2
/test e2e-aws-ovn-serial-publicnet-2of2
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-single-node-serial
/test e2e-aws-ovn-single-node-techpreview
/test e2e-aws-ovn-single-node-techpreview-serial
/test e2e-aws-ovn-single-node-upgrade
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-upgrade-rollback
/test e2e-aws-ovn-upi
/test e2e-aws-proxy
/test e2e-azure
/test e2e-azure-ovn-etcd-scaling
/test e2e-azure-ovn-upgrade
/test e2e-baremetalds-kubevirt
/test e2e-external-aws
/test e2e-external-aws-ccm
/test e2e-external-vsphere-ccm
/test e2e-gcp-disruptive
/test e2e-gcp-fips-serial-1of2
/test e2e-gcp-fips-serial-2of2
/test e2e-gcp-ovn-etcd-scaling
/test e2e-gcp-ovn-rt-upgrade
/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-techpreview-serial-1of2
/test e2e-gcp-ovn-techpreview-serial-2of2
/test e2e-gcp-ovn-usernamespace
/test e2e-hypershift-conformance
/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-bgp-virt-dualstack
/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
/test e2e-metal-ipi-ovn-dualstack-local-gateway
/test e2e-metal-ipi-ovn-kube-apiserver-rollout
/test e2e-metal-ipi-serial-1of2
/test e2e-metal-ipi-serial-2of2
/test e2e-metal-ipi-serial-ovn-ipv6-1of2
/test e2e-metal-ipi-serial-ovn-ipv6-2of2
/test e2e-metal-ipi-virtualmedia
/test e2e-metal-ovn-single-node-live-iso
/test e2e-metal-ovn-single-node-with-worker-live-iso
/test e2e-metal-ovn-two-node-arbiter
/test e2e-metal-ovn-two-node-fencing
/test e2e-openstack-ovn
/test e2e-openstack-serial
/test e2e-test-image-stream-import-mode-techpreview
/test e2e-vsphere-ovn-dualstack-primaryv6
/test e2e-vsphere-ovn-etcd-scaling
/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-main-e2e-aws-csi
pull-ci-openshift-origin-main-e2e-aws-ovn-fips
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2
pull-ci-openshift-origin-main-e2e-gcp-csi
pull-ci-openshift-origin-main-e2e-gcp-ovn
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-origin-main-e2e-vsphere-ovn
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi
pull-ci-openshift-origin-main-go-verify-deps
pull-ci-openshift-origin-main-images
pull-ci-openshift-origin-main-lint
pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn
pull-ci-openshift-origin-main-okd-scos-images
pull-ci-openshift-origin-main-unit
pull-ci-openshift-origin-main-verify
pull-ci-openshift-origin-main-verify-deps

In response to this:

/test openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ormergi
Copy link
Contributor Author

ormergi commented Oct 19, 2025

/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview

@maiqueb
Copy link
Contributor

maiqueb commented Oct 20, 2025

/verified by ci

This adds two tests, which are passing.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 20, 2025
@openshift-ci-robot
Copy link

@maiqueb: This PR has been marked as verified by ci.

In response to this:

/verified by ci

This adds two tests, which are passing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@kyrtapz
Copy link
Contributor

kyrtapz commented Oct 20, 2025

/approve

Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, maiqueb, ormergi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2025
@maiqueb
Copy link
Contributor

maiqueb commented Oct 20, 2025

/retest-required

@maiqueb
Copy link
Contributor

maiqueb commented Oct 20, 2025

Regarding the verify-deps failed job; maybe you need to rebase ?
@kyrtapz do you thing that would address the failure we're seeing in https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30314/pull-ci-openshift-origin-main-go-verify-deps/1979805300932218880 ?

@kyrtapz
Copy link
Contributor

kyrtapz commented Oct 20, 2025

Regarding the verify-deps failed job; maybe you need to rebase ? @kyrtapz do you thing that would address the failure we're seeing in https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30314/pull-ci-openshift-origin-main-go-verify-deps/1979805300932218880 ?

This looks like a fairly recent issue which I don't think was fixed just yet.
See: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1760866756540319?thread_ts=1760539927.386709&cid=C01CQA76KMX

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 43159a2 and 2 for PR HEAD 0c58f2a in total

@ormergi
Copy link
Contributor Author

ormergi commented Oct 20, 2025

/retest-required

Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

@ormergi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial c7dbb14 link false /test e2e-aws-ovn-single-node-serial
ci/prow/okd-scos-e2e-aws-ovn 0c58f2a link false /test okd-scos-e2e-aws-ovn
ci/prow/go-verify-deps 0c58f2a link true /test go-verify-deps
ci/prow/e2e-aws-ovn-microshift 0c58f2a link true /test e2e-aws-ovn-microshift
ci/prow/e2e-gcp-ovn 0c58f2a link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-microshift-serial 0c58f2a link true /test e2e-aws-ovn-microshift-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-trt bot commented Oct 20, 2025

Job Failure Risk Analysis for sha: 0c58f2a

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift IncompleteTests
Tests for this run (19) are below the historical average (1652): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial IncompleteTests
Tests for this run (19) are below the historical average (879): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn IncompleteTests
Tests for this run (21) are below the historical average (3364): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 0c58f2a

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview Medium - "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using NetworkAttachmentDefinitions [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC address is created when the address is already taken" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview Medium - "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC address is created when the address is already taken" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 0c58f2a

  • "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using NetworkAttachmentDefinitions [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC address is created when the address is already taken" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC address is created when the address is already taken" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants