Default MetricStorage NetworkAttachments to ctlplane#827
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f39d1351ff2349968c081ab8464f9879 ✔️ openstack-k8s-operators-content-provider SUCCESS in 57m 55s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5d35876c89884b759063abdca1fee62a ✔️ openstack-k8s-operators-content-provider SUCCESS in 59m 25s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8ccff3636cb34d07b2913c8f3e082d69 ✔️ openstack-k8s-operators-content-provider SUCCESS in 59m 53s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2a9e299272f34edc9e9a641abf210883 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 18m 09s |
|
CI issues seem unrelated to the change |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c6ee37a2bfbf41f9bd9e11f1eb695ad9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 56m 55s |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vkmc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks for the review Emma! I missed that |
|
Kuttl tests are failing since the NAD required for tests/default is not available When inspecting the logs, I noticed that the user supplied namespace creation is being skipped for all tests. I think this is an issue that should be fixed in a follow up patch. For this PR, I added the NAD creation as a step in default/tests |
vkmc
force-pushed
the
OSPRH-22189/use-dataplane-nw-default-nad
branch
from
66204d4 to
78d50f6
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3d70a6fa7e824443bba7f40e0fa9e467 ❌ openstack-k8s-operators-content-provider FAILURE in 13m 16s |
|
recheck |
|
/retest |
vkmc
force-pushed
the
OSPRH-22189/use-dataplane-nw-default-nad
branch
from
78d50f6 to
90f720d
Compare
|
Testing status of Kuttl tests in main in #836 to understand better the output in this PR For some reason, after adding the NAD in the default test, Prometheus fail to start with an storage issue If we do have a resources issue, this should be happening in main as well. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/41dcda669a0c46b687ddcb124f3c7716 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 50s |
| - script: | | ||
| oc apply -f deps/loki-operator.yaml | ||
| until oc api-resources | grep -q grafana; do sleep 1; done | ||
| - script: oc apply -n telemetry-kuttl-tests -f https://raw.githubusercontent.com/openstack-k8s-operators/infra-operator/main/config/samples/network_v1beta1_netconfig.yaml |
There was a problem hiding this comment.
It seems that you are applying the NetConfig configuration to the wrong namespace. I think that our tests are actually running in telemetry-kuttl-default namespace.
Maybe changing the namespace here fixes the issue you are seeing.
There was a problem hiding this comment.
There was a problem hiding this comment.
Unfortunately didn't do the trick. We set the namespace for kuttl tests in https://github.com/openstack-k8s-operators/telemetry-operator/blob/main/kuttl-test.yaml#L19. The config for individual kuttl tests https://github.com/openstack-k8s-operators/telemetry-operator/blob/main/test/kuttl/tests/default/kuttl-test.yaml#L5 is being skipped (for all tests, we have the lines
=== CONT kuttl/harness/default
logger.go:42: 15:54:16 | default | Ignoring deps as it does not match file name regexp: ^(\d+)-(?:[^\.]+)(?:\.yaml)?$
logger.go:42: 15:54:16 | default | Ignoring kuttl-test.yaml as it does not match file name regexp: ^(\d+)-(?:[^\.]+)(?:\.yaml)?$
logger.go:42: 15:54:16 | default | Ignoring output as it does not match file name regexp: ^(\d+)-(?:[^\.]+)(?:\.yaml)?$
logger.go:42: 15:54:16 | default | Skipping creation of user-supplied namespace: telemetry-kuttl-tests
)
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/42503d098d974bc88be0b8ee96569d17 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 06m 20s |
vkmc
force-pushed
the
OSPRH-22189/use-dataplane-nw-default-nad
branch
from
1910d23 to
52eb95a
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3a27506b34424d0f837764ee830aef99 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 11s |
Updates the MetricStorage CRD to default NetworkAttachments to ["ctlplane"]. This aligns the field with DataplaneNetwork and removes the manual requirement for users to override this in the OpenStackControlPlane CR. Closes: OSPRH-22189
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4d284cab973f4129a9bead3f9f9366f9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 35s |
Add defaulting logic to set NetworkAttachments to ["ctlplane"]
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/64270b4725494555b462db600197aede ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 22s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a481a243ad75430684def9e647c97828 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 30s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0e03dce3e68448dd949f1ec8841593ba ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 54s |
api/v1beta1/metricstorage_webhook.go
Outdated
| if len(spec.NetworkAttachments) == 0 { | ||
| spec.NetworkAttachments = []string{"ctlplane"} | ||
| } | ||
|
|
There was a problem hiding this comment.
as discussed on slack, so far, and as far as I am aware of, we are not defaulting any NetworkAttachment in operators, because the name can be anything, it must not be ctlplane. I am not against doing it, but in theory, depending on the OCP config and routing config, you might be able to use it just via the pod network and routing via the OCP worker node.
iiuc this code part here will not allow to deploy without any configured NAD, I am not sure if that is a forced config we want to do? I think it is fine to default it to ctlplane, but let the user to override to an empty list
There was a problem hiding this comment.
Fair enough, just updated the PR to drop this, thanks for looking into it!
Prow Kuttl is not running with network isolation (see https://github.com/openshift/release/blob/main/ci-operator/step-registry/openstack-k8s-operators/kuttl/openstack-k8s-operators-kuttl-commands.sh#L88) Because of this, we cannot get a working NAD to use for the MetricStorage (we are missing the NNCP required to create the NAD) By default, we now set 'ctlplane' as the NAD (if no other value is set). If we don't have a working NAD, the MetricStorage fails to deploy. To overcome this limitation, we can structure tests as follow - For all tests that require a working MetricStorage, we can pass an empty list (relying on the routingViaHost config) - In order to test that the NAD annotation is added to the MetricStorage (without the proper MetricStorage being deployed), we create a non working NAD and check the corresponding annotation is in place. We currently do this in the TLS Kuttl scenario.
We shouldn't force the NetworkAttachments to be set to 'ctlplane' Allow override for NetworkAttachments to an empty list. This is required for cases in which the routing is done via the OCP worker node (as in CI)
vkmc
force-pushed
the
OSPRH-22189/use-dataplane-nw-default-nad
branch
from
9f4b680 to
1c4698c
Compare
|
Let's see if passing an empty list for NAD allow get us to passing Kuttl jobs. Once this is done, I will drop the unnecessary resources creation and debugging steps. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9c368244ab6c4909835a584315bd503f ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 40s |
|
recheck |
Keep the NAD creation in the test step
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3199f85a2fdd40749f442a6a005bf35e ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 29s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9089f1168c374afca841a88d4b3cba42 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 26s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/00fa6c9bdf024201bf4eb874bb1eac00 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 29s |
|
/recheck |
1 similar comment
|
/recheck |
5 participants
Updates the MetricStorage CRD to default NetworkAttachments to ["ctlplane"]. This aligns the field with DataplaneNetwork and removes the manual requirement for users to override this in the OpenStackControlPlane CR.
Closes: OSPRH-22189