Skip to content

chore: DSPX-1236 allow using proper endpoints for OIDC #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ntrevino-virtru
Copy link
Contributor

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ntrevino-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility of the OIDC authentication providers by allowing explicit configuration of the token and user info endpoints. This change makes the library compatible with OIDC identity providers that may not use the standard endpoint paths.

Highlights

  • Configurable OIDC Endpoints: Introduced optional oidcTokenEndpoint and oidcUserInfoEndpoint parameters to OIDC credentials and provider constructors, allowing users to specify custom endpoints instead of relying on the default paths relative to oidcOrigin.
  • Internal Endpoint Handling: The internal AccessToken class now stores and uses the provided token and user info endpoints for making requests, falling back to the standard /protocol/openid-connect/token and /protocol/openid-connect/userinfo paths if custom ones are not configured.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to specify custom OIDC token and userinfo endpoints, providing more flexibility for integrating with different OIDC providers. The changes involve adding new optional parameters to the configuration types and constructors, and updating the AccessToken class to use these parameters with fallbacks to the default paths. The implementation appears correct, but adding documentation for the new configuration options would improve clarity for users.

Comment on lines +15 to +16
oidcTokenEndpoint?: string;
oidcUserInfoEndpoint?: string;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Add JSDoc comments for the new oidcTokenEndpoint and oidcUserInfoEndpoint properties in the CommonCredentials type to explain their purpose and how they are used.

Suggested change
oidcTokenEndpoint?: string;
oidcUserInfoEndpoint?: string;
oidcTokenEndpoint?: string;
/** The endpoint of the OIDC IdP userinfo endpoint, ex. 'https://virtru.com/auth/protocol/openid-connect/userinfo' */
oidcUserInfoEndpoint?: string;

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ntrevino-virtru ntrevino-virtru marked this pull request as ready for review June 10, 2025 16:57
@ntrevino-virtru ntrevino-virtru requested a review from a team as a code owner June 10, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant