-
Notifications
You must be signed in to change notification settings - Fork 3
chore: remove streamsaver dependency #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @eugenioenko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on removing the deprecated streamsaver
dependency from the web-app
. This involves not only deleting the dependency from configuration files but also re-architecting the file download mechanism to use standard browser APIs, ensuring the application remains functional without the removed library.
Highlights
- Dependency Removal: The
streamsaver
dependency and its associated TypeScript types have been completely removed from the project'spackage.json
andpackage-lock.json
files. - File Download Logic Re-implementation: The
toFile
utility function inweb-app/src/App.tsx
has been re-implemented to no longer rely onstreamsaver
. It now uses native browser APIs (ReadableStream, Blob, URL.createObjectURL, and programmatic<a>
element clicks) to handle file downloads. - Transitive Dependency Updates: The
package-lock.json
file has been updated, reflecting the removal ofstreamsaver
and including various minor version bumps for@babel
andbrace-expansion
related packages, likely due to anpm install
oryarn install
run after the primary dependency removal.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the deprecated streamsaver
dependency. The core change involves a rewrite of the toFile
function in App.tsx
. While the new implementation is functional and handles abort signals, it now accumulates the entire file content in memory before initiating a download. This is a significant change from streamsaver
's streaming approach and could impact performance for large files.
If these changes look good, signoff on them with:
If they aren't any good, please remove them with:
|
8d8aa58
to
f2b7042
Compare
f2b7042
to
78f526c
Compare
|
Remove deprecated streamsaver dependency