Move module multipaz-models into multipaz as a package. #1335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koukarine
force-pushed
the
models_merge
branch
from
68ad9b9 to
c0d4766
Compare
|
I would also drop the |
koukarine
force-pushed
the
models_merge
branch
5 times, most recently
from
c37b159 to
2c653a0
Compare
koukarine
force-pushed
the
models_merge
branch
2 times, most recently
from
48cb8b6 to
1095a1c
Compare
davidz25
reviewed
Oct 28, 2025
...androidInstrumentedTest/kotlin/org/multipaz/presentment/model/MatcherDcqlQueryExecuteTest.kt
Outdated
Show resolved
Hide resolved
...androidInstrumentedTest/kotlin/org/multipaz/presentment/model/MatcherDcqlQueryExecuteTest.kt
Show resolved
Hide resolved
...androidInstrumentedTest/kotlin/org/multipaz/presentment/model/MatcherDcqlQueryExecuteTest.kt
Outdated
Show resolved
Hide resolved
multipaz/src/commonTest/kotlin/org/multipaz/presentment/model/DocumentStoreTestHarness.kt
Outdated
Show resolved
Hide resolved
multipaz/src/javaSharedMain/kotlin/org/multipaz/crypto/EcPrivateKeyJvm.kt
Show resolved
Hide resolved
davidz25
reviewed
Oct 28, 2025
koukarine
force-pushed
the
models_merge
branch
2 times, most recently
from
845b02b to
e5bd684
Compare
davidz25
reviewed
Oct 29, 2025
multipaz/src/androidInstrumentedTest/kotlin/org/multipaz/testUtil.android.kt
Show resolved
Hide resolved
Test: All Unit tests are passing (bar Longfellow). Test: Manually tested via samples/testapp on Android. Signed-off-by: koukarine <[email protected]>
koukarine
force-pushed
the
models_merge
branch
from
e5bd684 to
204ed6b
Compare
davidz25
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move multipaz-models code to the multipaz module.
Test: All Unit tests are passing (bar Longfellow).
Test: Manually tested via samples/testapp on Android.
Fixes #1334