Move logic related to allreduce out of process op method. #785
+92
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_812750842
branch
from
b3529ed to
d5f2452
Compare
It is a refactoring. It prepares to move some of it to allreduce logic. Also move the check for overflow axes out. This way, it guarantees to return non-empty AxesPerFactor in the full version. PiperOrigin-RevId: 812750842
copybara-service
bot
force-pushed
the
test_812750842
branch
from
d5f2452 to
d84fe5b
Compare
copybara-service
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move logic related to allreduce out of process op method.
It is a refactoring.
It prepares to move some of it to allreduce logic.
Also move the check for overflow axes out. This way, it guarantees to return non-empty AxesPerFactor in the full version.