fix: labelSelector emptiness check #459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this test is mostly useless, both for testing this fix and in general 😢 because whether we set the selector predicate on the watch has no influence on the explicit ("manual") execution of
Reconcile()
that this test does.In order to test whether WithSelector has any effect, we'd have to invoke the controller manager, because that is where the filtering happens.
Probably something like this test does.
However this is a more involved undertaking than I have time for right now, so just sending this fix alone at this time.
cc @kurlov
Fixes: #458