Merged
Conversation
openshift-ci
bot
added
the
needs-rebase
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
openshift-ci
bot
removed
the
needs-rebase
There was a problem hiding this comment.
Pull request overview
Updates this Spring Boot starter to use Java Operator SDK (JOSDK) 5.3.1, adjusting code to account for upstream API changes.
Changes:
- Bump
josdk.versionfrom5.2.3to5.3.1. - Replace
ReconcilerUtilsusages withReconcilerUtilsInternalin starter code and tests. - Update sample YAML-loading helpers to import
ReconcilerUtilsInternal.loadYaml.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
pom.xml |
Bumps the managed JOSDK dependency version to 5.3.1. |
starter/src/main/java/.../OperatorAutoConfiguration.java |
Switches reconciler name resolution to ReconcilerUtilsInternal for property lookup/registration. |
starter/src/test/java/.../AutoConfigurationTest.java |
Updates test reconciler-name lookup to match the new JOSDK utility class. |
samples/webpage/.../ServiceDependentResource.java |
Updates YAML loading import to ReconcilerUtilsInternal.loadYaml. |
samples/webpage/.../DeploymentDependentResource.java |
Updates YAML loading import to ReconcilerUtilsInternal.loadYaml. |
samples/webpage/.../Utils.java |
Updates YAML loading import to ReconcilerUtilsInternal.loadYaml. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| public BiConsumer<Operator, Reconciler<?>> reconcilerRegisterer() { | ||
| return (operator, reconciler) -> { | ||
| var name = ReconcilerUtils.getNameFor(reconciler); | ||
| var name = ReconcilerUtilsInternal.getNameFor(reconciler); |
Comment on lines
+71
to
+72
| config.getReconcilers().get(ReconcilerUtilsInternal.getNameFor(TestReconciler.class)) | ||
| .getRetry(); |
| import io.javaoperatorsdk.operator.springboot.starter.sample.webpage.customresource.WebPage; | ||
|
|
||
| import static io.javaoperatorsdk.operator.ReconcilerUtils.loadYaml; | ||
| import static io.javaoperatorsdk.operator.ReconcilerUtilsInternal.loadYaml; |
| import io.javaoperatorsdk.operator.springboot.starter.sample.webpage.customresource.WebPage; | ||
|
|
||
| import static io.javaoperatorsdk.operator.ReconcilerUtils.loadYaml; | ||
| import static io.javaoperatorsdk.operator.ReconcilerUtilsInternal.loadYaml; |
| import io.javaoperatorsdk.operator.springboot.starter.sample.webpage.customresource.WebPageStatus; | ||
|
|
||
| import static io.javaoperatorsdk.operator.ReconcilerUtils.loadYaml; | ||
| import static io.javaoperatorsdk.operator.ReconcilerUtilsInternal.loadYaml; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com