🐛 CRD upgrade safety ratcheting

[joelanford]

Description

This fixes a bug in the CRD upgrade preflight safety check that causes errors to be reported even when schemas of a CRD have not changed between bundle versions.

The current logic of the CRD checker always reports all issues found in the rountrippability between versions in the new CRD. However if those exact same problems exist in the existing CRD, then the upgrade is not making the situation any worse, so the check should not fail.

NOTE: I have this setup as a WIP because I don't want to use my fork's implementation. We should wait until kubernetes-sigs/crdify#32 merges, and then bump our crdify dependency to pull the fix in.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	e27ff46
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/6888f8bd29086500080ecdc0
😎 Deploy Preview	https://deploy-preview-2123--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tmshort for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.60%. Comparing base (0206ad4) to head (e27ff46).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2123      +/-   ##
==========================================
+ Coverage   73.59%   73.60%   +0.01%     
==========================================
  Files          78       78              
  Lines        7260     7260              
==========================================
+ Hits         5343     5344       +1     
+ Misses       1567     1566       -1     
  Partials      350      350              

Flag	Coverage Δ
e2e	43.50% <ø> (?)
experimental-e2e	56.17% <ø> (ø)
unit	58.88% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.