Skip to content

WIP: PR to test PR 3686 #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

WIP: PR to test PR 3686 #3687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffe981e
fix: Use rest.HTTPClientFor to create TLS-configured client for metri…
jianzhangbjz Oct 24, 2025
7809e7a
run metrics test with pr-3686
anik120 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pkg/lib/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"fmt"
"net/http"
"path/filepath"
"time"

"github.com/operator-framework/operator-lifecycle-manager/pkg/lib/filemonitor"
"github.com/operator-framework/operator-lifecycle-manager/pkg/lib/profile"
Expand Down Expand Up @@ -110,10 +109,14 @@ func (sc serverConfig) getListenAndServeFunc() (func() error, error) {
// Set up authenticated metrics endpoint if kubeConfig is provided
if sc.kubeConfig != nil && tlsEnabled {
sc.logger.Info("Setting up authenticated metrics endpoint")
// Create HTTP client with proper TLS configuration from kubeConfig
// This is necessary for TokenReview/SubjectAccessReview API calls to verify API server certificates
httpClient, err := rest.HTTPClientFor(sc.kubeConfig)
if err != nil {
return nil, fmt.Errorf("failed to create http client for authentication: %w", err)
}
// Create authentication filter using controller-runtime
filter, err := filters.WithAuthenticationAndAuthorization(sc.kubeConfig, &http.Client{
Timeout: 30 * time.Second,
})
filter, err := filters.WithAuthenticationAndAuthorization(sc.kubeConfig, httpClient)
if err != nil {
return nil, fmt.Errorf("failed to create authentication filter: %w", err)
}
Expand Down
Loading