-
Notifications
You must be signed in to change notification settings - Fork 6
Add check for empty list of schema #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA check was added to the Changes
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying infrahub-sdk-python with
|
Latest commit: |
8c71f45
|
Status: | ✅ Deploy successful! |
Preview URL: | https://c49d2abc.infrahub-sdk-python.pages.dev |
Branch Preview URL: | https://bkr-fix-load-schemas.infrahub-sdk-python.pages.dev |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## stable #472 +/- ##
==========================================
- Coverage 75.63% 75.61% -0.03%
==========================================
Files 100 100
Lines 8767 8770 +3
Branches 1714 1715 +1
==========================================
Hits 6631 6631
- Misses 1660 1662 +2
- Partials 476 477 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
changelog/461.fixed.md (1)
1-1
: Fix spelling and minor wording issues.
relationshhip
→relationship
,prefecthing
→prefetching
; also consider singular “node” for consistency.-Fixes processing of relationshhip during nodes retrieval using the Sync Client, when prefecthing related_nodes. +Fixes processing of relationship during node retrieval using the Sync Client, when prefetching related_nodes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
changelog/461.fixed.md
(1 hunks)changelog/469.fixed.md
(1 hunks)changelog/fixed.md
(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- changelog/469.fixed.md
- changelog/fixed.md
🧰 Additional context used
🪛 LanguageTool
changelog/461.fixed.md
[grammar] ~1-~1: Ensure spelling is correct
Context: Fixes processing of relationshhip during nodes retrieval using the Sync C...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: unit-tests (3.13)
- GitHub Check: unit-tests (3.12)
- GitHub Check: unit-tests (3.10)
- GitHub Check: unit-tests (3.11)
- GitHub Check: unit-tests (3.9)
- GitHub Check: integration-tests-latest-infrahub
- GitHub Check: Cloudflare Pages
Handle the error 500 on backend as well with opsmill/infrahub#6835 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file looks wrong to me, it shouldn't exist in the first place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there is no bug/issue in Github, which ID should be used?
Summary by CodeRabbit