Skip to content

Add check for empty list of schema #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

Add check for empty list of schema #472

merged 2 commits into from
Jul 22, 2025

Conversation

BeArchiTek
Copy link
Contributor

@BeArchiTek BeArchiTek commented Jul 16, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling to notify users and exit if no valid files are found when loading YAML files.

Copy link

coderabbitai bot commented Jul 16, 2025

Walkthrough

A check was added to the load_yamlfile_from_disk_and_exit function to detect when no valid YAML files are loaded. If the file list is empty, an error message is printed and the program exits with code 1. Minor punctuation fixes were made in multiple changelog files. No changes were made to function signatures or other logic.

Changes

File Change Summary
infrahub_sdk/ctl/utils.py Added empty file list check and exit in function.
changelog/fixed.md Added missing period and documented new fix about empty schema lists.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2025

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c71f45
Status: ✅  Deploy successful!
Preview URL: https://c49d2abc.infrahub-sdk-python.pages.dev
Branch Preview URL: https://bkr-fix-load-schemas.infrahub-sdk-python.pages.dev

View logs

Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/ctl/utils.py 0.00% 2 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##           stable     #472      +/-   ##
==========================================
- Coverage   75.63%   75.61%   -0.03%     
==========================================
  Files         100      100              
  Lines        8767     8770       +3     
  Branches     1714     1715       +1     
==========================================
  Hits         6631     6631              
- Misses       1660     1662       +2     
- Partials      476      477       +1     
Flag Coverage Δ
integration-tests 34.65% <0.00%> (-0.02%) ⬇️
python-3.10 47.86% <0.00%> (-0.02%) ⬇️
python-3.11 47.89% <0.00%> (-0.02%) ⬇️
python-3.12 47.84% <0.00%> (-0.02%) ⬇️
python-3.13 47.84% <0.00%> (-0.02%) ⬇️
python-3.9 46.56% <0.00%> (-0.02%) ⬇️
python-filler-3.12 25.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/utils.py 68.08% <0.00%> (-1.49%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
changelog/461.fixed.md (1)

1-1: Fix spelling and minor wording issues.

relationshhiprelationship, prefecthingprefetching; also consider singular “node” for consistency.

-Fixes processing of relationshhip during nodes retrieval using the Sync Client, when prefecthing related_nodes.
+Fixes processing of relationship during node retrieval using the Sync Client, when prefetching related_nodes.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 121c94d and 8c71f45.

📒 Files selected for processing (3)
  • changelog/461.fixed.md (1 hunks)
  • changelog/469.fixed.md (1 hunks)
  • changelog/fixed.md (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • changelog/469.fixed.md
  • changelog/fixed.md
🧰 Additional context used
🪛 LanguageTool
changelog/461.fixed.md

[grammar] ~1-~1: Ensure spelling is correct
Context: Fixes processing of relationshhip during nodes retrieval using the Sync C...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: unit-tests (3.13)
  • GitHub Check: unit-tests (3.12)
  • GitHub Check: unit-tests (3.10)
  • GitHub Check: unit-tests (3.11)
  • GitHub Check: unit-tests (3.9)
  • GitHub Check: integration-tests-latest-infrahub
  • GitHub Check: Cloudflare Pages

@BeArchiTek
Copy link
Contributor Author

Handle the error 500 on backend as well with opsmill/infrahub#6835

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file looks wrong to me, it shouldn't exist in the first place

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is no bug/issue in Github, which ID should be used?

@dgarros dgarros merged commit 19a03ae into stable Jul 22, 2025
20 checks passed
@dgarros dgarros deleted the bkr-fix-load-schemas branch July 22, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants