Allow user to cancel proposed changes actions #6846

pa-lem · 2025-07-17T13:21:34Z

Add select button to choose which action to trigger on a proposed change
Allow user to cancel approve / reject actions

codspeed-hq · 2025-07-17T13:28:15Z

CodSpeed Performance Report

Merging #6846 will not alter performance

_{Comparing ple-pc-actions (ce2f394) with develop (ad6ad03)}

Summary

✅ 10 untouched benchmarks

…ions

coderabbitai · 2025-07-22T11:08:01Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch ple-pc-actions

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…ions

ajtmccarty

setting approved_by and rejected_by to read-only makes sense to me

…ions

bilalabbad · 2025-07-23T13:25:30Z

frontend/app/src/entities/proposed-changes/api/updateReviewFromApi.ts

+  decision: string;
+}
+
+export function udpateReviewFromApi({


There is a typo udpate

I suggest to add more context in the name of the function: Review -> ProposedChangeReview

bilalabbad · 2025-07-23T13:26:17Z

frontend/app/src/entities/proposed-changes/api/updateReviewFromApi.ts

+  branchName,
+}: UpdateReviewFromApiApiParams) {
+  return graphqlClient.mutate({
+    mutation: gql(MUTATION),


use gql in the query directly to have graphql autocompletion and highlight.

bilalabbad · 2025-07-23T13:26:45Z

frontend/app/src/entities/proposed-changes/api/updateReviewFromApi.ts

+      decision,
+    },
+    context: {
+      branch: branchName,


is branch really needed? Are proposed change branch-agnostic?

bilalabbad · 2025-07-23T13:27:48Z

frontend/app/src/entities/proposed-changes/constants.ts

+
+export const PROPOSED_CHANGE_STATES = {
+  opened: ["open", "merging"],
+  closed: ["closed", "merged", "canceled"],


you could reuse const declared above

bilalabbad · 2025-07-23T13:29:18Z

frontend/app/src/entities/proposed-changes/domain/update-review.mutation.ts

+        branchName: currentBranch.name,
+      });
+    },
+    mutationKey: ["propose-changes-action"],


mutationKey is not needed

bilalabbad · 2025-07-23T13:30:02Z

frontend/app/src/entities/proposed-changes/domain/update-review.ts

+
+export type UpdateReview = (data: UpdateReviewFromApiApiParams) => Promise<void>;
+
+export const updateReview: UpdateReview = async (params) => {


same here and on hooks. Add more context on function name. It's too wide rn

bilalabbad · 2025-07-23T13:49:52Z

frontend/app/src/entities/proposed-changes/utils/has-user-rejected.ts

+import { User } from "@/entities/authentication/ui/useAuth";
+import { NodeObject } from "@/entities/nodes/types";
+
+export const hasUserRejected = (proposedChangesDetails: NodeObject, user: User | null) => {


name is again too broad. hasUserRejected -> hasUserRejectedProposedChange

Also, from the name, I'd expect user not to be null. If it is null, that should be handled earlier before calling the function.

bilalabbad · 2025-07-23T13:50:08Z

frontend/app/src/entities/proposed-changes/utils/has-user-approved.ts

+import { User } from "@/entities/authentication/ui/useAuth";
+import { NodeObject } from "@/entities/nodes/types";
+
+export const hasUserApproved = (proposedChangesDetails: NodeObject, user: User | null) => {


same than about hasUserRejected

bilalabbad · 2025-07-23T14:18:32Z

frontend/app/src/entities/proposed-changes/ui/proposed-change-details.tsx

            approvers={approvers}
            proposedChangeId={proposedChangeId!}
            state={state}
            disabled={!permission.update.isAllowed}


the new component PcActionButton seems to not take props?

bilalabbad · 2025-07-23T14:19:44Z

frontend/app/src/entities/proposed-changes/ui/action-button/approve-button.tsx

+
+  const { mutateAsync, isPending } = useUpdateReview({
+    onSuccess: async () => {
+      await graphqlClient.reFetchObservableQueries();


missing update on query using tanstack query no?

tanstack is not used (yet...) for the details view

bilalabbad · 2025-07-23T14:20:14Z

frontend/app/src/entities/proposed-changes/ui/action-button/approve-button.tsx

+  const handleAction = (event: React.MouseEvent<HTMLButtonElement>) => {
+    event.stopPropagation();
+
+    mutateAsync({


use normal mutate instead of mutateAsync is there is no await

ogenstad and others added 5 commits July 16, 2025 09:48

Add mutation to review a proposed change

ac0e8bf

Add approved_by / rejected_by logic

915b16a

minor changes

8c52a4c

Set approved_by and reject_by as readonly

1302a36

rename undo to cancel

b3ef6aa

github-actions bot added the group/frontend Issue related to the frontend (React) label Jul 17, 2025

pa-lem added 4 commits July 17, 2025 15:22

remove components

548bde6

add use update

cccd278

add use update review

6f4606a

add actions button

6011c5b

pa-lem force-pushed the ple-pc-actions branch from 107bb3e to 6011c5b Compare July 17, 2025 13:22

github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Jul 17, 2025

pa-lem added 7 commits July 17, 2025 21:30

start add actions

e75f1e6

update constants

7693c9d

update constants

5098b4d

Merge branch 'develop' of github.com:opsmill/infrahub into ple-pc-act…

002d8c2

…ions

add action buttons

aaf4268

add open close button

f9247de

add reject and update constants

247f355

Merge branch 'develop' of github.com:opsmill/infrahub into ple-pc-act…

45837df

…ions

pa-lem changed the title ~~Ple pc actions~~ Allow user to cancel proposed changes actions Jul 22, 2025

pa-lem marked this pull request as ready for review July 22, 2025 13:29

pa-lem requested review from a team as code owners July 22, 2025 13:29

pa-lem added 3 commits July 22, 2025 15:31

fix merge develop

dc3679f

add placeholde button if not logged in

8d198e1

handle disabled states

a5c2d51

ajtmccarty approved these changes Jul 22, 2025

View reviewed changes

pa-lem added 6 commits July 22, 2025 17:10

update test

dd15c61

fix update in list view

e83db69

lint

ec3edc4

lint

f016c68

Merge branch 'develop' of github.com:opsmill/infrahub into ple-pc-act…

e9897ce

…ions

add rejected by

d682a2f

bilalabbad reviewed Jul 23, 2025

View reviewed changes

pa-lem added 9 commits July 23, 2025 16:07

add fragment

7cd2ad1

typo

94d55ba

rename

36ae3ff

update const

d99a124

🔧

10fcb0d

remove key

5ea55dc

rename

cad3ab0

update types

e2f532d

rename files

a9a6bbf

bilalabbad reviewed Jul 23, 2025

View reviewed changes

pa-lem added 4 commits July 23, 2025 16:21

remove props

dccae81

use mutate

21ab3e1

remove unused

42e0799

remove unused query

9c26545

pa-lem requested a review from bilalabbad July 23, 2025 15:54

update

ce2f394

bilalabbad approved these changes Jul 24, 2025

View reviewed changes

pa-lem merged commit fd80582 into develop Jul 24, 2025
40 checks passed

pa-lem deleted the ple-pc-actions branch July 24, 2025 13:42


		export type UpdateReview = (data: UpdateReviewFromApiApiParams) => Promise<void>;

		export const updateReview: UpdateReview = async (params) => {

Allow user to cancel proposed changes actions #6846

Allow user to cancel proposed changes actions #6846

Uh oh!

Conversation

pa-lem commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging #6846 will not alter performance

Summary

Uh oh!

coderabbitai bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

ajtmccarty left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pa-lem commented Jul 17, 2025 •

edited

Loading

codspeed-hq bot commented Jul 17, 2025 •

edited

Loading

coderabbitai bot commented Jul 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)