Skip to content

Add git-commit skill definition - #8451

Merged
BeArchiTek merged 4 commits into
stablefrom
claude/commit-command
Feb 25, 2026
Merged

Add git-commit skill definition#8451
BeArchiTek merged 4 commits into
stablefrom
claude/commit-command

Conversation

@BeArchiTek

@BeArchiTek BeArchiTek commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation
    • Added a comprehensive guided workflow for conventional commits: step-by-step staging, diff/history inspection, message composition templates and conventions (types, scope, line length, multi-line notes), heredoc multi-line guidance, allowed tooling and argument hints, amend and push handling (including force-with-lease), verification steps, and safety rules to avoid exposing secrets or sensitive files.

@BeArchiTek BeArchiTek self-assigned this Feb 23, 2026
@BeArchiTek BeArchiTek added type/housekeeping Maintenance task type/task Body of work related to an epic labels Feb 23, 2026
@coderabbitai

coderabbitai Bot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e6c7f7 and 7acb682.

📒 Files selected for processing (1)
  • dev/commands/git-commit.md

Walkthrough

Adds dev/commands/git-commit.md, a new guide documenting a guided workflow for staging, composing, and pushing changes using conventional commits. It defines allowed tools and argument hints, describes step-by-step actions (repo state inspection, diff and history review, conventional-format message composition including multiline/heredoc and amend workflows, user confirmation, staging, committing, upstream-aware pushing with force-with-lease for amended commits), and lists commit-message guidelines and safety rules.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely missing; no content was provided by the author despite the template being available. Add a pull request description using the repository template to explain the purpose, changes, testing approach, and any relevant context for reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a new git-commit skill definition document.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
dev/commands/git-commit.md (1)

12-12: git stash is declared in allowed-tools but never used in any step.

No step in the workflow invokes git stash. If stash support isn't intentionally reserved for future use, remove it to keep the allowed-tools surface minimal and avoid misleading an agent.

🧹 Proposed fix
   - Bash(git branch:*)
-  - Bash(git stash:*)
   - Bash(git rev-parse:*)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@dev/commands/git-commit.md` at line 12, The documentation declares "git
stash" in the allowed-tools list but no workflow step calls it; remove the
unused allowed-tool entry for "git stash" from the allowed-tools section in
dev/commands/git-commit.md (search for the literal "git stash" or the Bash(git
stash:*) entry) so the allowed-tools surface only contains tools actually
invoked by steps and won't mislead agents.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@dev/commands/git-commit.md`:
- Line 149: Fix the typo in the documentation line that currently reads "Never
force push to `stable` or `develop` branche" by changing "branche" to "branches"
so the sentence reads "Never force push to `stable` or `develop` branches";
update the text in dev/commands/git-commit.md where that sentence appears.
- Line 41: Step 2's enumeration of commit types omits "style" causing
inconsistency with the format section; update the sentence that currently lists
"feat, fix, docs, refactor, test, chore" to include "style" so it reads "feat,
fix, docs, style, refactor, test, chore" (refer to the Step 2 instruction and
the format/guidelines references in the same document).
- Around line 64-67: The guide currently instructs to always run "git add -A"
which will stage all changes even when the user intends to use "--amend" only to
change the commit message; update the instructions in dev/commands/git-commit.md
to conditionally run staging: mirror the logic used in step 7 by adding a branch
that runs "git add -A" only when creating a new commit or when amending with new
changes, and explicitly skip running "git add -A" when the user is amending
solely to edit the commit message (i.e., amend-only case).
- Around line 102-105: Add an inline protected-branch guard immediately before
the 'git push --force-with-lease' instruction: detect the current branch (e.g.,
via 'git rev-parse --abbrev-ref HEAD') and if it equals the protected names
'stable' or 'develop', abort and print a clear warning instead of running the
force-push; otherwise continue to run the force-with-lease push. This keeps the
existing guidance but prevents accidental force-pushes to protected branches by
checking the branch name before executing the 'git push --force-with-lease'
step.

---

Nitpick comments:
In `@dev/commands/git-commit.md`:
- Line 12: The documentation declares "git stash" in the allowed-tools list but
no workflow step calls it; remove the unused allowed-tool entry for "git stash"
from the allowed-tools section in dev/commands/git-commit.md (search for the
literal "git stash" or the Bash(git stash:*) entry) so the allowed-tools surface
only contains tools actually invoked by steps and won't mislead agents.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 36603cb and 60fc7c5.

📒 Files selected for processing (1)
  • dev/commands/git-commit.md

Comment thread dev/commands/git-commit.md
Comment thread dev/commands/git-commit.md
Comment thread dev/commands/git-commit.md
Comment thread dev/commands/git-commit.md Outdated
@BeArchiTek
BeArchiTek requested review from a team February 23, 2026 16:50
Comment thread dev/commands/git-commit.md Outdated
@BeArchiTek
BeArchiTek merged commit 3551fa1 into stable Feb 25, 2026
31 of 33 checks passed
@BeArchiTek
BeArchiTek deleted the claude/commit-command branch February 25, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/housekeeping Maintenance task type/task Body of work related to an epic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants