-
Notifications
You must be signed in to change notification settings - Fork 46
Implementation of backend plotting for profile_plot
#645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Ping @timmens for review. I have made the suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very nice!
I have a few questions / requested changes.
…tplotlib margin properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Approved!
I only have a tiny comment. You can merge the PR after fixing that.
Thanks for merging! Information about Tidy Dataframe:As per the previous implementation, the With the new backend plotting system, a tidy DataFrame is no longer required. Therefore, the data extraction logic could potentially be simplified. Unfortunately, I couldn't find a way to do this without effectively performing the same operations required to tidy the DataFrame, which therefore, might not provide any significant improvement in terms of complexity. |
This PR refactors
profile_plot()
to use the backend plotting module.Backends
Plot Changes
PR Checklist