Skip to content

[FSSDK-11731] windows version update #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 38 additions & 2 deletions .github/workflows/csharp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
netFrameworksAndUnitTest:
name: Build Framework & Run Unit Tests
needs: [ lintCodebase ]
runs-on: windows-2019 # required version for Framework 4.0
runs-on: windows-2022
env:
REPO_SLUG: ${{ github.repository }}
BUILD_NUMBER: ${{ github.run_id }}
Expand All @@ -44,15 +44,51 @@ jobs:
uses: microsoft/setup-msbuild@v1
- name: Setup NuGet
uses: NuGet/setup-nuget@v1
- name: Download and Extract .NET Framework Reference Assemblies
run: |
# Create temp directory
New-Item -ItemType Directory -Path "temp_ref_assemblies" -Force

# Download .NET 4.0 Reference Assemblies
echo "Downloading .NET 4.0 Reference Assemblies..."
Invoke-WebRequest -Uri "https://www.nuget.org/api/v2/package/Microsoft.NETFramework.ReferenceAssemblies.net40/1.0.3" -OutFile "temp_ref_assemblies/net40_ref.zip"

# Download .NET 4.5 Reference Assemblies
echo "Downloading .NET 4.5 Reference Assemblies..."
Invoke-WebRequest -Uri "https://www.nuget.org/api/v2/package/Microsoft.NETFramework.ReferenceAssemblies.net45/1.0.3" -OutFile "temp_ref_assemblies/net45_ref.zip"

# Extract .NET 4.0 Reference Assemblies
echo "Extracting .NET 4.0 Reference Assemblies..."
Expand-Archive -Path "temp_ref_assemblies/net40_ref.zip" -DestinationPath "temp_ref_assemblies/net40" -Force
if (Test-Path "temp_ref_assemblies/net40/build/.NETFramework/v4.0") {
echo "✓ .NET 4.0 Reference Assemblies extracted to workspace"
}

# Extract .NET 4.5 Reference Assemblies
echo "Extracting .NET 4.5 Reference Assemblies..."
Expand-Archive -Path "temp_ref_assemblies/net45_ref.zip" -DestinationPath "temp_ref_assemblies/net45" -Force
if (Test-Path "temp_ref_assemblies/net45/build/.NETFramework/v4.5") {
echo "✓ .NET 4.5 Reference Assemblies extracted to workspace"
}
- name: Restore NuGet packages
run: nuget restore ./OptimizelySDK.NETFramework.sln
- name: Build & strongly name assemblies
run: msbuild /p:SignAssembly=true /p:AssemblyOriginatorKeyFile=$(pwd)/keypair.snk /p:Configuration=Release ./OptimizelySDK.NETFramework.sln
run: |
# Build with workspace-relative reference assembly paths
$Net40RefPath = "$(pwd)\temp_ref_assemblies\net40\build\.NETFramework\v4.0"
$Net45RefPath = "$(pwd)\temp_ref_assemblies\net45\build\.NETFramework\v4.5"

echo "Using .NET 4.0 Reference Assemblies from: $Net40RefPath"
echo "Using .NET 4.5 Reference Assemblies from: $Net45RefPath"

msbuild /p:SignAssembly=true /p:AssemblyOriginatorKeyFile=$(pwd)/keypair.snk /p:Configuration=Release /p:FrameworkPathOverride="$Net45RefPath" ./OptimizelySDK.NETFramework.sln
- name: Install & Run NUnit tests
run: |
nuget install NUnit.Console -Version 3.18.1 -DirectDownload -OutputDirectory .
# https://docs.nunit.org/articles/nunit/running-tests/Console-Command-Line.html
./NUnit.ConsoleRunner.3.18.1\tools\nunit3-console.exe /timeout 10000 /process Separate ./OptimizelySDK.Tests/bin/Release/OptimizelySDK.Tests.dll
- name: Cleanup reference assemblies
run: Remove-Item -Path "temp_ref_assemblies" -Recurse -Force

netStandard16:
name: Build Standard 1.6
Expand Down
44 changes: 40 additions & 4 deletions .github/workflows/csharp_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
buildFrameworkVersions:
name: Build Framework versions
needs: [ variables ]
runs-on: windows-2019 # required version for Framework 4.0
runs-on: windows-2022
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -41,10 +41,46 @@ jobs:
uses: microsoft/setup-msbuild@v2
- name: Setup NuGet
uses: nuget/setup-nuget@v2
- name: Download and Extract .NET Framework Reference Assemblies
run: |
# Create temp directory
New-Item -ItemType Directory -Path "temp_ref_assemblies" -Force

# Download .NET 4.0 Reference Assemblies
echo "Downloading .NET 4.0 Reference Assemblies..."
Invoke-WebRequest -Uri "https://www.nuget.org/api/v2/package/Microsoft.NETFramework.ReferenceAssemblies.net40/1.0.3" -OutFile "temp_ref_assemblies/net40_ref.zip"

# Download .NET 4.5 Reference Assemblies
echo "Downloading .NET 4.5 Reference Assemblies..."
Invoke-WebRequest -Uri "https://www.nuget.org/api/v2/package/Microsoft.NETFramework.ReferenceAssemblies.net45/1.0.3" -OutFile "temp_ref_assemblies/net45_ref.zip"

# Extract .NET 4.0 Reference Assemblies
echo "Extracting .NET 4.0 Reference Assemblies..."
Expand-Archive -Path "temp_ref_assemblies/net40_ref.zip" -DestinationPath "temp_ref_assemblies/net40" -Force
if (Test-Path "temp_ref_assemblies/net40/build/.NETFramework/v4.0") {
echo "✓ .NET 4.0 Reference Assemblies extracted to workspace"
}

# Extract .NET 4.5 Reference Assemblies
echo "Extracting .NET 4.5 Reference Assemblies..."
Expand-Archive -Path "temp_ref_assemblies/net45_ref.zip" -DestinationPath "temp_ref_assemblies/net45" -Force
if (Test-Path "temp_ref_assemblies/net45/build/.NETFramework/v4.5") {
echo "✓ .NET 4.5 Reference Assemblies extracted to workspace"
}
- name: Restore NuGet packages
run: nuget restore ./OptimizelySDK.NETFramework.sln
- name: Build and strongly name assemblies
run: msbuild /p:SignAssembly=true /p:AssemblyOriginatorKeyFile=$(pwd)/keypair.snk /p:Configuration=Release ./OptimizelySDK.NETFramework.sln
run: |
# Build with workspace-relative reference assembly paths
$Net40RefPath = "$(pwd)\temp_ref_assemblies\net40\build\.NETFramework\v4.0"
$Net45RefPath = "$(pwd)\temp_ref_assemblies\net45\build\.NETFramework\v4.5"

echo "Using .NET 4.0 Reference Assemblies from: $Net40RefPath"
echo "Using .NET 4.5 Reference Assemblies from: $Net45RefPath"

msbuild /p:SignAssembly=true /p:AssemblyOriginatorKeyFile=$(pwd)/keypair.snk /p:Configuration=Release /p:FrameworkPathOverride="$Net45RefPath" ./OptimizelySDK.NETFramework.sln
- name: Cleanup reference assemblies
run: Remove-Item -Path "temp_ref_assemblies" -Recurse -Force
- name: Upload Framework artifacts
uses: actions/upload-artifact@v4
with:
Expand All @@ -55,7 +91,7 @@ jobs:
buildStandard16:
name: Build Standard 1.6 version
needs: [ variables ]
runs-on: windows-latest
runs-on: windows-2022
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -77,7 +113,7 @@ jobs:
buildStandard20:
name: Build Standard 2.0 version
needs: [ variables ]
runs-on: windows-latest
runs-on: windows-2022
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down
45 changes: 0 additions & 45 deletions .github/workflows/sonarqube.yml

This file was deleted.

Loading