-
Notifications
You must be signed in to change notification settings - Fork 32
[FSSDK-11522] feat: update decision service to apply ho #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5cb4eb3
fix: update method parameters in Optimizely.java and Bucketer.java to…
muzahidul-opti b7f169b
feat: add holdout rule support in DecisionService
muzahidul-opti c68b096
fix(core-api): fix bucket method parameter in Bucketer.java
muzahidul-opti d8068e2
fix: correct visibility and initialization of constants in ValidProje…
muzahidul-opti 8f831f1
test: add tests for holdout feature in DecisionServiceTest
muzahidul-opti 524fc9f
feat: add HOLDOUT_TYPEDAUDIENCE_HOLDOUT to ValidProjectConfigV4
muzahidul-opti c17e2a6
fix(core-api): update Experiment import to ExperimentCore in FeatureD…
muzahidul-opti 2bd5e17
chore: clarify holdout logs and replace wildcards
muzahidul-opti 56ab9f1
test: add holdout decision test to verify behavior
muzahidul-opti 1f33478
refactor: rename test from 'decide_holdoutApplied_basic' to 'decide_w…
muzahidul-opti 2e98731
fix: update eventHandler call to include 'nationality' for impression…
muzahidul-opti 62b24a9
Add decision notification test case for ho
muzahidul-opti 075fd4e
Revert back original test cases
muzahidul-opti 5a1cca2
feat: add method for handling decision notifications with holdouts
muzahidul-opti 3ea6d9e
Revert original test cases
muzahidul-opti 8b36afd
feat: implement decision notification handling with holdouts
muzahidul-opti d8fc1e4
feat(core-api): deprecate ExperimentCore and replace with Experiment …
muzahidul-opti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.