-
Notifications
You must be signed in to change notification settings - Fork 83
[FSSDK-12026] add customHeaders option to polling config manager #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for custom HTTP headers in the polling datafile manager configuration. This allows users to pass additional headers that will be included in all datafile fetch requests.
Key Changes:
- Added
customHeadersparameter toPollingConfigManagerConfigandDatafileManagerConfigtypes - Updated
PollingDatafileManagerto merge custom headers with existing headers (Authorization, if-modified-since) - Added comprehensive test coverage for custom headers functionality
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
lib/project_config/polling_datafile_manager.ts |
Added customHeaders property and implementation to merge custom headers into datafile requests |
lib/project_config/polling_datafile_manager.spec.ts |
Added test cases for custom headers functionality including standalone usage and merging with other headers |
lib/project_config/datafile_manager.ts |
Added customHeaders field to DatafileManagerConfig type definition |
lib/project_config/config_manager_factory.ts |
Added customHeaders to PollingConfigManagerConfig type and passed it through to datafile manager |
lib/project_config/config_manager_factory.spec.ts |
Updated tests to verify customHeaders is properly passed through the factory |
lib/project_config/config_manager_factory.react_native.ts |
Updated copyright year and reorganized imports |
lib/project_config/config_manager_factory.react_native.spec.ts |
Updated copyright year and added customHeaders to test configuration |
lib/project_config/config_manager_factory.node.ts |
Updated copyright year and reorganized imports |
lib/project_config/config_manager_factory.node.spec.ts |
Updated copyright year and added customHeaders to test configuration |
lib/project_config/config_manager_factory.browser.ts |
Updated copyright year and reorganized imports |
lib/project_config/config_manager_factory.browser.spec.ts |
Updated copyright year and added customHeaders to test configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b66b5ac to
9a6b319
Compare
Issues