Skip to content

Conversation

@raju-opti
Copy link
Contributor

Issues

  • FSSDK-12026

@coveralls
Copy link

coveralls commented Nov 14, 2025

Coverage Status

coverage: 78.231% (-0.006%) from 78.237%
when pulling 9a6b319 on raju/custom-header
into dca1913 on master.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom HTTP headers in the polling datafile manager configuration. This allows users to pass additional headers that will be included in all datafile fetch requests.

Key Changes:

  • Added customHeaders parameter to PollingConfigManagerConfig and DatafileManagerConfig types
  • Updated PollingDatafileManager to merge custom headers with existing headers (Authorization, if-modified-since)
  • Added comprehensive test coverage for custom headers functionality

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
lib/project_config/polling_datafile_manager.ts Added customHeaders property and implementation to merge custom headers into datafile requests
lib/project_config/polling_datafile_manager.spec.ts Added test cases for custom headers functionality including standalone usage and merging with other headers
lib/project_config/datafile_manager.ts Added customHeaders field to DatafileManagerConfig type definition
lib/project_config/config_manager_factory.ts Added customHeaders to PollingConfigManagerConfig type and passed it through to datafile manager
lib/project_config/config_manager_factory.spec.ts Updated tests to verify customHeaders is properly passed through the factory
lib/project_config/config_manager_factory.react_native.ts Updated copyright year and reorganized imports
lib/project_config/config_manager_factory.react_native.spec.ts Updated copyright year and added customHeaders to test configuration
lib/project_config/config_manager_factory.node.ts Updated copyright year and reorganized imports
lib/project_config/config_manager_factory.node.spec.ts Updated copyright year and added customHeaders to test configuration
lib/project_config/config_manager_factory.browser.ts Updated copyright year and reorganized imports
lib/project_config/config_manager_factory.browser.spec.ts Updated copyright year and added customHeaders to test configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@raju-opti raju-opti merged commit 4b35644 into master Nov 14, 2025
11 of 17 checks passed
@raju-opti raju-opti deleted the raju/custom-header branch November 14, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants