[FSSDK-11458] Python - Add SDK Multi-Region Support for Data Hosting #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o esra/FSSDK-11458_eu_hosting
raju-opti
requested changes
Jul 25, 2025
| ) | ||
|
|
||
| self.assertEqual(self.project_config.region, impression_event.event_context.region) | ||
| self.assertEqual('EU', impression_event.event_context.region) |
There was a problem hiding this comment.
can we also add a test for create_contervsion_event?
| @@ -576,7 +576,7 @@ def __init__(self, is_updated=False): | |||
| self.is_updated = is_updated | |||
|
|
|||
| def dispatch_event(self, log_event): | |||
| if log_event.http_verb == 'POST' and log_event.url == EventFactory.EVENT_ENDPOINT: | |||
| if log_event.url in EventFactory.EVENT_ENDPOINTS.values(): | |||
There was a problem hiding this comment.
the log_event.http_verb == 'POST' condition got removed. Can we keep that check?
| EventFactory.EVENT_ENDPOINTS.get('US'), | ||
| expected_params, | ||
| EventFactory.HTTP_VERB, | ||
| EventFactory.HTTP_HEADERS, | ||
| ) |
There was a problem hiding this comment.
can we add a test to check that create_log_event works correctly with EU region?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues