Fix issue 81 #91
Merged
Fix issue 81 #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tests/update_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestUpdateWithCustomTableName(t *testing.T) { |
There was a problem hiding this comment.
Thanks for fixing the issue! Could you please uncomment the related test in TestToSQL in tests/sql_builder_test.go as well? Thanks a lot!
shelly-li-sl
approved these changes
Oct 10, 2025
ting-lan-wang
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect soft-delete table reference when performing updates with a custom table name (via clause.Update{Table: ...}). Fixes #81
Result
-- generated SQL : UPDATE "custom_update_table" SET "updated_at"='2025-10-08 23:16:47.41',"name"='patched',"age"=99 WHERE id = 200 AND "custom_update_table"."deleted_at" IS NULL