Skip to content

Reverting track md logs for error logging #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2025
Merged

Reverting track md logs for error logging #1225

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4749ae6
removed log parsing from MD Work request polling
agrimk Jul 11, 2025
d280d1d
Merge branch 'track_md_logs_for_error_logging' of github.com:oracle/a…
agrimk Jul 11, 2025
056b442
fixing test cases
agrimk Jul 11, 2025
9f7c2bc
Merge branch 'main' into track_md_logs_for_error_logging
agrimk Jul 11, 2025
2a584b0
updated toml file and release notes
agrimk Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions ads/aqua/modeldeployment/deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,6 @@ def _create_deployment(
logger.info(
f"Aqua model deployment {deployment_id} created for model {aqua_model_id}. Work request Id is {deployment.dsc_model_deployment.workflow_req_id}"
)
status_list = []

progress_thread = threading.Thread(
target=self.get_deployment_status,
Expand Down Expand Up @@ -1316,45 +1315,24 @@ def get_deployment_status(
poll_interval=DEFAULT_POLL_INTERVAL,
)
except Exception:
status = ""
logs = deployment.show_logs().sort_values(by="time", ascending=False)

if logs and len(logs) > 0:
status = logs.iloc[0]["message"]

status = re.sub(r"[^a-zA-Z0-9]", " ", status)

if data_science_work_request._error_message:
error_str = ""
for error in data_science_work_request._error_message:
error_str = error_str + " " + error.message

error_str = re.sub(r"[^a-zA-Z0-9]", " ", error_str)
telemetry_kwargs = {
"ocid": ocid,
"model_name": model_name,
"work_request_error": error_str,
"status": status,
}

self.telemetry.record_event(
category=f"aqua/{model_type}/deployment/status",
action="FAILED",
**telemetry_kwargs,
)
else:
telemetry_kwargs = {
"ocid": ocid,
"model_name": model_name,
"status": status,
"work_request_error": error_str,
}

self.telemetry.record_event(
category=f"aqua/{model_type}/deployment/status",
action="FAILED",
**telemetry_kwargs,
)

else:
telemetry_kwargs = {"ocid": ocid, "model_name": model_name}
self.telemetry.record_event(
Expand Down
1 change: 0 additions & 1 deletion tests/unitary/with_extras/aqua/test_deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2441,7 +2441,6 @@ def test_get_deployment_status_failed(self):
self.assertEqual(kwargs["category"], f"aqua/{model_type}/deployment/status")
self.assertEqual(kwargs["action"], "FAILED")
self.assertIn("work_request_error", kwargs)
self.assertIn("status", kwargs)
self.assertIn("ocid", kwargs)
self.assertIn("model_name", kwargs)

Expand Down
Loading