-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Detect cold CallTarget invalidation and reset its profile; Limit number of recompilations within a time period #11610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JohnTortugo
wants to merge
5
commits into
oracle:master
Choose a base branch
from
JohnTortugo:recompilations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+169
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chumer
requested changes
Jul 22, 2025
...racle.truffle.runtime/src/com/oracle/truffle/runtime/hotspot/HotSpotOptimizedCallTarget.java
Outdated
Show resolved
Hide resolved
...racle.truffle.runtime/src/com/oracle/truffle/runtime/hotspot/HotSpotOptimizedCallTarget.java
Outdated
Show resolved
Hide resolved
...m.oracle.truffle.runtime/src/com/oracle/truffle/runtime/OptimizedTruffleRuntimeListener.java
Show resolved
Hide resolved
truffle/src/com.oracle.truffle.runtime/src/com/oracle/truffle/runtime/OptimizedCallTarget.java
Outdated
Show resolved
Hide resolved
truffle/src/com.oracle.truffle.runtime/src/com/oracle/truffle/runtime/OptimizedCallTarget.java
Outdated
Show resolved
Hide resolved
chumer
reviewed
Aug 4, 2025
...src/jdk.graal.compiler.test/src/jdk/graal/compiler/truffle/test/MaximumCompilationsTest.java
Outdated
Show resolved
Hide resolved
logic for resetting call target profile.
@chumer, I did a refactoring of the code following your suggestions. Basically, I changed two things:
I tested the latest changes using the approach described in the issue ticket and everything worked fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11045
Please review this patch that modifies Truffle to:
Reset a CallTarget's profile when the
nmethod
associated with it was invalidated by HotSpot because the Code Cache's method flushing heuristics deemed the nmethod to be cold.Limit the number of compilations that a CallTarget can have within a time period. This doesn't change the current behavior, instead it just makes the constraint more flexible. I added a new parameter,
MaximumCompilationsWindow
, that the user can set to specify a time window within which the number of compilations will be limited (currently the window is whole duration of application execution).Tests: