Skip to content

[GR-67785] Fix detach_all_threads_and_tear_down_isolate. #11719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -688,11 +688,11 @@ private static class DetachAllExternallyStartedThreadsExceptCurrentOperation ext

@Override
protected void operate() {
IsolateThread currentThread = CurrentIsolate.getCurrentThread();
IsolateThread operationThread = CurrentIsolate.getCurrentThread();
IsolateThread thread = firstThread();
while (thread.isNonNull()) {
IsolateThread next = nextThread(thread);
if (thread.notEqual(currentThread) && !wasStartedByCurrentIsolate(thread)) {
if (thread.notEqual(queuingThread) && thread.notEqual(operationThread) && !wasStartedByCurrentIsolate(thread)) {
/*
* The code below is similar to VMThreads.detachCurrentThread() except that it
* doesn't call VMThreads.threadExit(). We assume that this is tolerable
Expand Down