Fix endsWith() to the correct version endswith() in mx_sdk_vm_impl.py
#12373
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l.py Apparently, the PR [[GR-70588] Include the GraalVM version rather than the Java version in the vendor version and basedir name](oracle#12319) (i.e. [commit 270badf](oracle@270badf) introduced a Python type because it used `endsWith()` instead of `endswith()`. This lets my builds fail. It's strange that thiy typo hasn't been caught by any tests
oracle-contributor-agreement
bot
added
the
OCA Verified
|
@gilles-duboscq, @daloze could you please have a quick look at this trivial fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, the PR [GR-70588] Include the GraalVM version rather than the Java version in the vendor version and basedir name (i.e. commit 270badf98ef4bb) introduced a Python typo because it used
endsWith()instead ofendswith(). This lets my builds fail.It's strange that thiy typo hasn't been caught by any tests