config:import first version - #1137
Open
carolnavarropereira wants to merge 6 commits into
Open
Conversation
carolnavarropereira
requested review from
a team and
alisyed-19
as code owners
August 17, 2026 08:01
oracle-contributor-agreement
Bot
added
the
OCA Verified
…1-support-importconfiguration
Comment on lines
+2
to
+6
| { | ||
| "commandName": "config:import", | ||
| "supportsInteractiveMode": false, | ||
| "generator": "commands/config/import/ImportConfigurationCommand" | ||
| }, |
Member
There was a problem hiding this comment.
I suggest we maintain command alphabetical order.
Therefore, let's declare config:import under account:setup:ci (line 22)
Member
Author
There was a problem hiding this comment.
I don't think it is important, but done it.
Comment on lines
+2
to
+16
| "config:import": { | ||
| "name": "config:import", | ||
| "description": "Imports the features from an account.", | ||
| "isSetupRequired": false, | ||
| "forceInteractiveMode": false, | ||
| "options": { | ||
| "authid": { | ||
| "name": "authid", | ||
| "description": "References the custom alias you give to a specific account-role combination. Referred to as authentication ID and auth ID in the documentation.", | ||
| "type": "SINGLE", | ||
| "mandatory": true, | ||
| "disableInIntegrationMode": false | ||
| } | ||
| } | ||
| }, |
Member
There was a problem hiding this comment.
I suggest we maintain command alphabetical order.
Therefore, Let's declare config:import under account:setup (line 34)
antoniofruci
approved these changes
Aug 18, 2026
alisyed-19
reviewed
Aug 20, 2026
Comment on lines
+106
to
+108
| await copyDirectoryContents(unzipFolder, targetFolder); | ||
|
|
||
| const statusItems = await parseImportObjectStatus(statusXml); |
Member
There was a problem hiding this comment.
Could we parse and validate status.xml (line 108) before copying the extracted files into targetFolder? If status parsing fails, this currently returns an error after potentially overwriting files under AccountConfiguration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.