Skip to content

Conversation

@pooja1pathak
Copy link
Collaborator

Proposed changes

Fix for #687. I have included comment on PR #691 .

Types of changes

What types of changes does your code introduce to the project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have run all the existing tests locally (not just those related to my feature) and there are no errors
  • After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
  • I have updated the RELEASE NOTES
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@c0c0n3
Copy link
Member

c0c0n3 commented Sep 19, 2024

@pooja1pathak thanks for this. Did you try running the WQ benchmark to see if it still works after the change?

@pooja1pathak
Copy link
Collaborator Author

@c0c0n3 I am unable to run WQ benchmark on my local setup due to some issue in timescale container. If possible, can you test my branch on your setup.

@c0c0n3
Copy link
Member

c0c0n3 commented Oct 18, 2024

@pooja1pathak can you try testing again, I've just merged #777 which might help...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants